Closed Bug 1317295 Opened 3 years ago Closed 3 years ago

Record PrintTarget::GetReferenceDrawTarget DrawTargets

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

Part of the story to fix bug 1310165 is that we need to record and replay the API calls on the DrawTargets returned from PrintTarget::GetReferenceDrawTarget.
Attached patch patchSplinter Review
Attachment #8810372 - Flags: review?(edwin)
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac5ea2dc6c60
Record PrintTarget::GetReferenceDrawTarget DrawTargets. r=edwin
I had to back this out (along with your other bugs pushed today) for windows vm debug failures like https://treeherder.mozilla.org/logviewer.html#?job_id=39173435&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/91b1add28ef64ca507a1c1c14db2031ae37c992b
Flags: needinfo?(jwatt)
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/32387613c305
Record PrintTarget::GetReferenceDrawTarget DrawTargets. r=edwin
(In reply to Wes Kocher (:KWierso) from comment #3)
> I had to back this out (along with your other bugs pushed today) for windows
> vm debug failures

It doesn't look like the patch for this bug was related to those failures.
Flags: needinfo?(jwatt)
https://hg.mozilla.org/mozilla-central/rev/32387613c305
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8810372 [details] [diff] [review]
patch

Requesting approval to uplift to v52 in order to get the initial content process sandboxing turned on.

Approval Request Comment
[Feature/regressing bug #]: bug 1314056
[User impact if declined]: less security
[Describe test coverage new/current, TreeHerder]: now merged to m-c
[Risks and why]: low risk
[String/UUID change made/needed]: none
Attachment #8810372 - Flags: approval-mozilla-aurora?
Comment on attachment 8810372 [details] [diff] [review]
patch

part of fix for printing issue with sandboxing on osx, for aurora52
Attachment #8810372 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.