Closed Bug 1317311 Opened 8 years ago Closed 8 years ago

Don't treat undefined fromIndex parameter as absent in TypedArray.prototype.lastIndexOf

Categories

(Core :: JavaScript: Standard Library, defect)

Product:
Core
Component:
JavaScript: Standard Library
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox52 --- affected
firefox53 --- fixed

People

(Reporter: anba, Assigned: anba)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

bug1317311.patch
4.50 KB, patch
evilpie
: review+
Details | Diff | Splinter Review
`assertEq(new Int8Array([10, 10]).lastIndexOf(10, undefined), 0)` should pass.
Attached patch bug1317311.patch — — Splinter Review
The two separate calls to CallTypedArrayMethodIfWrapped are needed because of bug 1138661.
Attachment #8810533 - Flags: review?(evilpies)
Attachment #8810533 - Flags: review?(evilpies) → review+
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/a4bc362f24cc Check for absent instead of undefined argument in TypedArray.prototype.lastIndexOf. r=evilpie
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a4bc362f24cc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: