Closed Bug 1317313 Opened 7 years ago Closed 7 years ago

Android Aurora Nightly's broken after merge day

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
Unspecified
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed, firefox53 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: cbook, Unassigned)

References

(
URL
)

Details

Attachments

(1 file)

Bug 1317313 - Unbust todays Android Aurora Nightly (post merge-day) by adding more to whitelist, and fixing regex.
58 bytes, text/x-review-board-request
cbook
: review+
mshal
: review+
Details 
https://treeherder.mozilla.org/logviewer.html#?job_id=4168768&repo=mozilla-aurora#L65102

 06:06:03     INFO -  09:06:03    ERROR -  make[3]: *** [stage-package] Error 1
 06:06:03     INFO -  09:06:03     INFO -  make[3]: Leaving directory `/builds/slave/m-aurora-and-api-15-ntly-00000/build/src/obj-firefox/mobile/android/installer'
 06:06:03     INFO -  09:06:03    ERROR -  make[2]: *** [make-package] Error 2
 06:06:03     INFO -  09:06:03     INFO -  make[2]: Leaving directory `/builds/slave/m-aurora-and-api-15-ntly-00000/build/src/obj-firefox/mobile/android/installer'
 06:06:03     INFO -  09:06:03    ERROR -  make[1]: *** [default] Error 2
 06:06:03     INFO -  09:06:03     INFO -  make[1]: Leaving directory `/builds/slave/m-aurora-and-api-15-ntly-00000/build/src/obj-firefox/mobile/android/installer'
06:06:03
Blocks: 1317333
Comment on attachment 8810422 [details]
Bug 1317313 - Unbust todays Android Aurora Nightly (post merge-day) by adding more to whitelist, and fixing regex.

https://reviewboard.mozilla.org/r/92746/#review92716
Attachment #8810422 - Flags: review?(cbook) → review+
looks ok to me
Comment on attachment 8810422 [details]
Bug 1317313 - Unbust todays Android Aurora Nightly (post merge-day) by adding more to whitelist, and fixing regex.

https://reviewboard.mozilla.org/r/92746/#review92714

::: toolkit/mozapps/installer/find-dupes.py:42
(Diff revision 1)
>      'chrome/en-US/locale/branding/brand.properties'
>      >>> normalize_l10n_path('chrome/fr/locale/fr/browser/aboutHome.dtd')
>      'chrome/en-US/locale/en-US/browser/aboutHome.dtd'
>      '''
> -    p = re.sub(r'chrome/(\S+)/locale/\1',
> -               'chrome/en-US/locale/en-US',
> +    # Keep a trailing slash here! e.g. locales like 'br' can transform
> +    # 'chrome/br/lcoale/branding/' into 'chrome/en-US/locale/en-USanding/'

nit: "lcoale" -> "locale"
Attachment #8810422 - Flags: review+
Pushed by Callek@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c765cdbfce28
Unbust todays Android Aurora Nightly (post merge-day) by adding more to whitelist, and fixing regex. r=mshal,Tomcat
https://hg.mozilla.org/mozilla-central/rev/c765cdbfce28
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.