Closed Bug 1317424 Opened 9 years ago Closed 9 years ago

Use the correct docShell ID when restoring SessionHistory for toplevel SHistory entries

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 944694

People

(Reporter: nika, Assigned: nika)

Details

While talking about session history and the requirements for the prerendering work, smaug explained that docshell IDs are not updated correctly during sessionrestore, such that the docshell ID of the restored SHistory entries is not correct. This patch changes sessionrestore to update the docshellIDs of toplevel entries to always be the docshellID of the target docShell.
Ah, great, I remember noticing the issue a few years ago but I couldn't find anybody to explain the docshellID to me so that we could fix it. Did you forget to attach the patch, by any chance?
Flags: needinfo?(michael)
Ah, found the original bug. Let's dup this one.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
I was going to attach my patch, but then I chatted a bit with olli on IRC, and my strategy for implementing this nicely may change a bit.
Flags: needinfo?(michael)
You need to log in before you can comment on or make changes to this bug.