1317473 - GMPServiceParent::AddOnGMPThread(path) can't handle a mixture of dir separators in path

Status: RESOLVED FIXED

(Core :: Audio/Video: GMP, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I see dom/media/tests/mochitest/test_peerConnection_basicH264Video.html fail when run locally on Windows because the mochitest harness is setting MOZ_GMP_PATH to a path which contains a mixture of UNIX and Windows path separators, and the NS_NewLocalFile() call in GMPServiceParent::AddOnGMPThread() is failing. We're then failing to add the fake OpenH264 plugin to the GMP service, and the WebRTC tests for H264 are failing.

Frankly, I don't know how they're working in automation at all; they're certainly failing locally, and they fail in automation when I have my work-in-progress patches for Bug 1316215 applied. Maybe the WebRTC H.264 tests are using gmp-clearkey on Windows by mistake? Yet another reason why we should be asking for GMPs by name, rather than capability.

We've had this sort of failure before, so I think we should just make the GMPService gracefully handle being passed paths with a mixture of dir separators, rather than fix the test harness to pass paths with consistent line endings; it'll probably just regress in future and break again.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1317473 - Make GMPService accept paths with mixed dir separators.

The mochitest harness on Windows sets MOZ_GMP_PATH to paths with a mixture of
Windows and UNIX dir separators, and the NS_NewLocalFile() call in
GMPServiceParent::AddOnGMPThread() fails on this input.

We've had this problem before, and if we fixed the test harness to give us
input with platform specific line endings somebody would likely just break this
again someday and have this issue again, so just make the GMP service normalize
the paths it's given to have consistent dir separators.

This makes test_peerConnection_basicH264Video.html pass when run
locally on my Windows machine.

Review commit: https://reviewboard.mozilla.org/r/92834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/92834/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8810594 [details]
Bug 1317473 - Make GMPService accept paths with mixed dir separators.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/92834/diff/1-2/

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8810594 [details]
Bug 1317473 - Make GMPService accept paths with mixed dir separators.

https://reviewboard.mozilla.org/r/92834/#review93152

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4fc83233df68
Make GMPService accept paths with mixed dir separators. r=jesup

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4fc83233df68