If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Don't send a sync ping for self-hosters

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Sync
P1
normal
RESOLVED FIXED
10 months ago
8 months ago

People

(Reporter: markh, Assigned: kitcambridge)

Tracking

unspecified
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
People self-hosting their sync servers can skew our stats, particularly if they don't upgrade the server components. For example, such users may account for pings that have a zero'd |uid|.

I initially thought we should just record the fact it is a custom config in the ping, but then thought we should just not bother sending a ping at all, which would probably better meet the expectations of those users.

I think just checking Services.prefs.prefHasUserValue("identity.sync.tokenserver.uri") is enough for this purpose - that will also exclude staging etc too, which I think is what we want. One consideration for the implementation is TPS - we probably *do* want to arrange for it to validate the ping it would have sent had it been against prod.

Comment 1

10 months ago
If we check and discard in the `submit` function, that will keep everything (TPS, etc) working.

I think this isn't just important for skewing our stats, I suspect that if you're self hosting sync, there's a decent chance you'd be unhappy with us sending telemetry about it (but maybe I'm wrong?).

Should be very short, will upload patch if I get a chance by the end of the day.
Priority: -- → P1
Assignee: nobody → kit
Comment hidden (mozreview-request)

Comment 3

8 months ago
mozreview-review
Comment on attachment 8826704 [details]
Bug 1317579 - Don't send a sync ping for self-hosters.

https://reviewboard.mozilla.org/r/104602/#review105980

Looks great, exactly the right place it needs to be to not break e.g. TPS even when configured to point somewhere strange.
Attachment #8826704 - Flags: review?(tchiovoloni) → review+

Comment 4

8 months ago
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35ae28472a13
Don't send a sync ping for self-hosters. r=tcsc

Comment 5

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/35ae28472a13
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
You need to log in before you can comment on or make changes to this bug.