1317599 - Get rid of LegacyIsCallerChromeOrNativeCode use in datatransfer

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Boris Zbarsky [:bzbarsky]]

We can use explicit caller type here.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Get rid of LegacyIsCallerChromeOrNativeCode use in datatransfer code

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8810734 [details] [diff] [review]
Get rid of LegacyIsCallerChromeOrNativeCode use in datatransfer code

Review of attachment 8810734 [details] [diff] [review]:
-----------------------------------------------------------------

This is much nicer than the old LegacyIsCallerChromeOrNativeCode version.

I wonder whether any of the other methods in DataTransfer{Item{List,},} which are currently [NeedsSubjectPrincipal] don't actually need the subject principal and could instead use this, as it seems nicer to call from C++.

I imagine that the only one which could handle that would likely be DataTransfer.types, as we need to do some principal comparisons for permissions checks in the DataTransferItemList::Data. Anyways, I think that is better for a follow up.

Comment 3

[Boris Zbarsky [:bzbarsky]]

I filed bug 1317720 on more places that can use NeedsCallerType.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7eecb6dbcc5
Get rid of LegacyIsCallerChromeOrNativeCode use in datatransfer code.  r=mystor

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e7eecb6dbcc5