Closed Bug 1317637 Opened 3 years ago Closed 3 years ago

Convert some code in gfx/ to C++11

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: andi, Assigned: andi)

References

Details

Attachments

(6 files)

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators
Assignee: nobody → bpostelnicu
Attachment #8810774 - Flags: review?(jmuizelaar)
Attachment #8810775 - Flags: review?(jmuizelaar)
Attachment #8810776 - Flags: review?(jmuizelaar)
Attachment #8810777 - Flags: review?(jmuizelaar)
Attachment #8810778 - Flags: review?(jmuizelaar)
Attachment #8810779 - Flags: review?(jmuizelaar)
Summary: Run clang-tidy on gfx/ module → Convert some code in gfx/ to C++11
Comment on attachment 8810776 [details]
Bug 1317637 - Replace default bodies of special member functions with = default; in gfx/.

https://reviewboard.mozilla.org/r/93110/#review93996
Attachment #8810776 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8810777 [details]
Bug 1317637 - Replace string literals containing escaped characters with raw string literals in gfx/.

https://reviewboard.mozilla.org/r/93112/#review94004
Attachment #8810777 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8810779 [details]
Bug 1317637 - Use C++11's override and remove virtual where applicable in gfx/.

https://reviewboard.mozilla.org/r/93116/#review94006
Attachment #8810779 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8810778 [details]
Bug 1317637 - Replace integer literals which are cast to bool in gfx/.

https://reviewboard.mozilla.org/r/93114/#review94008
Attachment #8810778 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8810775 [details]
Bug 1317637 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in gfx/.

https://reviewboard.mozilla.org/r/93108/#review94016
Attachment #8810775 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8810774 [details]
Bug 1317637 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in gfx/.

https://reviewboard.mozilla.org/r/93106/#review93994
Attachment #8810774 - Flags: review?(jmuizelaar) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f22d8216433d
Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in gfx/. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/b47802143664
Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in gfx/. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/705438010893
Replace default bodies of special member functions with = default; in gfx/. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/c7809b8a260a
Replace string literals containing escaped characters with raw string literals in gfx/. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/39e581da7b37
Replace integer literals which are cast to bool in gfx/. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/4b3318ca32ae
Use C++11's override and remove virtual where applicable in gfx/. r=jrmuizel
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.