1317660 - Fix CID 1394336: Resource leaks in TestAudioPacketizer.cpp

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[James Cheng[:JamesCheng]]

If the assertion_true not passed, it will not delete the buffer resource and cause a leak[1].

Just a simple fix.

[1]
http://searchfox.org/mozilla-central/rev/886d5186f0598ab2f8a9953eb5a4dab9750ef834/dom/media/gtest/TestAudioPacketizer.cpp#157

Comment 1

[James Cheng[:JamesCheng]]

Attachment: Bug 1317660 - Fix CID 1394336: Resource leaks in TestAudioPacketizer.cpp

Review commit: https://reviewboard.mozilla.org/r/93136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93136/

Comment 2

[Paul Adenot (:padenot)]

Comment on attachment 8810797 [details]
Bug 1317660 - Fix CID 1394336: Resource leaks in TestAudioPacketizer.cpp

https://reviewboard.mozilla.org/r/93136/#review93174

Can you implement my suggestion and land ? Thanks !

::: dom/media/gtest/TestAudioPacketizer.cpp:154
(Diff revision 1)
>            }
>            phase++;
>          }
>          ap.Input(b.Get(), 128);
>          while (ap.PacketsAvailable()) {
>            int16_t* packet = ap.Output();

std::unique_ptr<int16_t>, this will call the destructor automatically when returning from the function in `ASSERT_TRUE`.

::: dom/media/gtest/TestAudioPacketizer.cpp:167
(Diff revision 1)
> +              }
> +              ASSERT_TRUE(result);
>              }
>              outPhase++;
>            }
>            delete [] packet;

We can remove this with the unique_ptr.

Comment 3

[James Cheng[:JamesCheng]]

Sure thank you.

Comment 4

[James Cheng[:JamesCheng]]

Comment on attachment 8810797 [details]
Bug 1317660 - Fix CID 1394336: Resource leaks in TestAudioPacketizer.cpp

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93136/diff/1-2/

Comment 5

[James Cheng[:JamesCheng]]

Comment on attachment 8810797 [details]
Bug 1317660 - Fix CID 1394336: Resource leaks in TestAudioPacketizer.cpp

Hi padenot,

Could you please review it again?

I use unique_ptr to replace all raw pointer usage.

Thanks.

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8810797 [details]
Bug 1317660 - Fix CID 1394336: Resource leaks in TestAudioPacketizer.cpp

https://reviewboard.mozilla.org/r/93136/#review93466

Comment 7

[James Cheng[:JamesCheng]]

Thanks for review.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/637eeed7d0d2
Fix CID 1394336: Resource leaks in TestAudioPacketizer.cpp r=padenot

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/637eeed7d0d2

Comment 10

[areya]

https://hg.mozilla.org/mozilla-central/rev/637eeed7d0d2