Closed Bug 1317706 Opened 5 years ago Closed 5 years ago

Remove Pose WebIDL because we can move the sharing implementation to our c++ code

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox52 --- fixed
firefox53 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

References

Details

Attachments

(1 file, 2 obsolete files)

As the discussion at Bug 1299932 Comment 68, we can share the implementation instead of sharing in Pose IDL, and it would make more sense for following the relevant specs.
Assignee: nobody → dmu
:bz, could you help me review this patch or I should ask for someone else because you don't accept for review currently.
Flags: needinfo?(bzbarsky)
Comment on attachment 8810891 [details] [diff] [review]
Bug 1317706 - Removing Pose WebIDL

You don't need to declare Pose::WrapObject at all.

r=me with that removed.
Flags: needinfo?(bzbarsky)
Attachment #8810891 - Flags: review+
V2:
Follow Comment 2 to remove Pose::WrapObject and carry the r+.
Attachment #8810891 - Attachment is obsolete: true
Attachment #8811081 - Flags: review+
has conflicts to apply:

1 out of 1 hunks FAILED -- saving rejects to file dom/webidl/moz.build.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh 0001-Bug-1317706-Removing-Pose-WebIDL-for-sharing-the-imp.patch
Flags: needinfo?(dmu)
Carry r+ from Comment 2 and according to Comment 5 to rebase to fix conflict.
Attachment #8811081 - Attachment is obsolete: true
Flags: needinfo?(dmu)
Attachment #8811739 - Flags: review+
Keywords: checkin-needed
I have done the rebase with the latest m-c source code, but I don't see any conflict.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5020b7acf45
Remove Pose WebIDL for sharing the implementation to Pose class. r=bz
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d5020b7acf45
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Depends on: 1332614
Comment on attachment 8811739 [details] [diff] [review]
Bug 1317706 - Removing Pose WebIDL (v3)

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1299932
[User impact if declined]: shipping something we shouldn't be to release users (see bug 1332614)
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just un-shipping something we don't want to ship.
[String changes made/needed]: None
Attachment #8811739 - Flags: approval-mozilla-aurora?
Comment on attachment 8811739 [details] [diff] [review]
Bug 1317706 - Removing Pose WebIDL (v3)

remove pose webidl, aurora52+
Attachment #8811739 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.