Closed
Bug 1317706
Opened 8 years ago
Closed 8 years ago
Remove Pose WebIDL because we can move the sharing implementation to our c++ code
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
People
(Reporter: daoshengmu, Assigned: daoshengmu)
References
Details
Attachments
(1 file, 2 obsolete files)
9.20 KB,
patch
|
daoshengmu
:
review+
jcristau
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
As the discussion at Bug 1299932 Comment 68, we can share the implementation instead of sharing in Pose IDL, and it would make more sense for following the relevant specs.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → dmu
Assignee | ||
Comment 1•8 years ago
|
||
:bz, could you help me review this patch or I should ask for someone else because you don't accept for review currently.
Flags: needinfo?(bzbarsky)
Comment 2•8 years ago
|
||
Comment on attachment 8810891 [details] [diff] [review] Bug 1317706 - Removing Pose WebIDL You don't need to declare Pose::WrapObject at all. r=me with that removed.
Flags: needinfo?(bzbarsky)
Attachment #8810891 -
Flags: review+
Assignee | ||
Comment 3•8 years ago
|
||
V2: Follow Comment 2 to remove Pose::WrapObject and carry the r+.
Attachment #8810891 -
Attachment is obsolete: true
Attachment #8811081 -
Flags: review+
Assignee | ||
Comment 4•8 years ago
|
||
Please help land Attachment #8811081 [details] [diff] to m-c Try looks good. https://treeherder.mozilla.org/#/jobs?repo=try&revision=65176892846241cc20e14e104be4936261504977
Keywords: checkin-needed
Comment 5•8 years ago
|
||
has conflicts to apply: 1 out of 1 hunks FAILED -- saving rejects to file dom/webidl/moz.build.rej patch failed, unable to continue (try -v) patch failed, rejects left in working directory errors during apply, please fix and qrefresh 0001-Bug-1317706-Removing-Pose-WebIDL-for-sharing-the-imp.patch
Flags: needinfo?(dmu)
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 6•8 years ago
|
||
Carry r+ from Comment 2 and according to Comment 5 to rebase to fix conflict.
Attachment #8811081 -
Attachment is obsolete: true
Flags: needinfo?(dmu)
Attachment #8811739 -
Flags: review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 7•8 years ago
|
||
I have done the rebase with the latest m-c source code, but I don't see any conflict.
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d5020b7acf45 Remove Pose WebIDL for sharing the implementation to Pose class. r=bz
Keywords: checkin-needed
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d5020b7acf45
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment 11•7 years ago
|
||
Comment on attachment 8811739 [details] [diff] [review] Bug 1317706 - Removing Pose WebIDL (v3) Approval Request Comment [Feature/Bug causing the regression]: Bug 1299932 [User impact if declined]: shipping something we shouldn't be to release users (see bug 1332614) [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: Just un-shipping something we don't want to ship. [String changes made/needed]: None
Attachment #8811739 -
Flags: approval-mozilla-aurora?
Comment 12•7 years ago
|
||
Comment on attachment 8811739 [details] [diff] [review] Bug 1317706 - Removing Pose WebIDL (v3) remove pose webidl, aurora52+
Attachment #8811739 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 13•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/970562d09078
status-firefox52:
--- → fixed
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•