1317757 - gfx/ipc/GPUProcessManager.cpp:329:39: error: 'SprintfLiteral' was not declared in this scope

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jan Beich]

In file included from objdir/gfx/ipc/Unified_cpp_gfx_ipc0.cpp:2:
In file included from gfx/ipc/CompositorSession.cpp:11:
In file included from objdir/dist/include/mozilla/layers/CompositorBridgeChild.h:15:
In file included from objdir/dist/include/mozilla/layers/TextureForwarder.h:13:
In file included from objdir/dist/include/mozilla/layers/TextureClient.h:27:
objdir/dist/include/mozilla/gfx/CriticalSection.h:54:3: warning: mutex 'mMutex' is still held
      at the end of function [-Wthread-safety-analysis]
  }
  ^
objdir/dist/include/mozilla/gfx/CriticalSection.h:52:26: note: mutex acquired here
    DebugOnly<int> err = pthread_mutex_lock(&mMutex);
                         ^
objdir/dist/include/mozilla/gfx/CriticalSection.h:57:26: warning: releasing mutex 'mMutex'
      that was not held [-Wthread-safety-analysis]
    DebugOnly<int> err = pthread_mutex_unlock(&mMutex);
                         ^
In file included from objdir/gfx/ipc/Unified_cpp_gfx_ipc0.cpp:56:
gfx/ipc/GPUProcessManager.cpp:328:5: error: use of undeclared identifier
      'SprintfLiteral'
    SprintfLiteral(disableMessage, "GPU process disabled after %d attempts",
    ^
2 warnings and 1 error generated.

Comment 1

[Jan Beich]

Attachment: Bug 1317757 - Explicitly include header for SprintfLiteral().

Review commit: https://reviewboard.mozilla.org/r/93226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93226/

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8810963 [details]
Bug 1317757 - Explicitly include header for SprintfLiteral().

https://reviewboard.mozilla.org/r/93226/#review93218

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d7f47206d367
Explicitly include header for SprintfLiteral(). r=milan

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d7f47206d367

Comment 5

[areya]

https://hg.mozilla.org/mozilla-central/rev/d7f47206d367