Closed Bug 1317757 Opened 3 years ago Closed 3 years ago

gfx/ipc/GPUProcessManager.cpp:329:39: error: 'SprintfLiteral' was not declared in this scope

Categories

(Core :: Graphics, defect)

Unspecified
FreeBSD
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: jbeich, Assigned: jbeich)

References

Details

(Keywords: regression, Whiteboard: [gfx-noted])

Attachments

(1 file)

In file included from objdir/gfx/ipc/Unified_cpp_gfx_ipc0.cpp:2:
In file included from gfx/ipc/CompositorSession.cpp:11:
In file included from objdir/dist/include/mozilla/layers/CompositorBridgeChild.h:15:
In file included from objdir/dist/include/mozilla/layers/TextureForwarder.h:13:
In file included from objdir/dist/include/mozilla/layers/TextureClient.h:27:
objdir/dist/include/mozilla/gfx/CriticalSection.h:54:3: warning: mutex 'mMutex' is still held
      at the end of function [-Wthread-safety-analysis]
  }
  ^
objdir/dist/include/mozilla/gfx/CriticalSection.h:52:26: note: mutex acquired here
    DebugOnly<int> err = pthread_mutex_lock(&mMutex);
                         ^
objdir/dist/include/mozilla/gfx/CriticalSection.h:57:26: warning: releasing mutex 'mMutex'
      that was not held [-Wthread-safety-analysis]
    DebugOnly<int> err = pthread_mutex_unlock(&mMutex);
                         ^
In file included from objdir/gfx/ipc/Unified_cpp_gfx_ipc0.cpp:56:
gfx/ipc/GPUProcessManager.cpp:328:5: error: use of undeclared identifier
      'SprintfLiteral'
    SprintfLiteral(disableMessage, "GPU process disabled after %d attempts",
    ^
2 warnings and 1 error generated.
Comment on attachment 8810963 [details]
Bug 1317757 - Explicitly include header for SprintfLiteral().

https://reviewboard.mozilla.org/r/93226/#review93218
Attachment #8810963 - Flags: review?(milan) → review+
Keywords: checkin-needed
Assignee: nobody → jbeich
Whiteboard: [gfx-noted]
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7f47206d367
Explicitly include header for SprintfLiteral(). r=milan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d7f47206d367
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.