Closed Bug 1317757 Opened 3 years ago Closed 3 years ago
Manager .cpp:329:39: error: 'Sprintf Literal' was not declared in this scope
58 bytes, text/x-review-board-request
In file included from objdir/gfx/ipc/Unified_cpp_gfx_ipc0.cpp:2: In file included from gfx/ipc/CompositorSession.cpp:11: In file included from objdir/dist/include/mozilla/layers/CompositorBridgeChild.h:15: In file included from objdir/dist/include/mozilla/layers/TextureForwarder.h:13: In file included from objdir/dist/include/mozilla/layers/TextureClient.h:27: objdir/dist/include/mozilla/gfx/CriticalSection.h:54:3: warning: mutex 'mMutex' is still held at the end of function [-Wthread-safety-analysis] } ^ objdir/dist/include/mozilla/gfx/CriticalSection.h:52:26: note: mutex acquired here DebugOnly<int> err = pthread_mutex_lock(&mMutex); ^ objdir/dist/include/mozilla/gfx/CriticalSection.h:57:26: warning: releasing mutex 'mMutex' that was not held [-Wthread-safety-analysis] DebugOnly<int> err = pthread_mutex_unlock(&mMutex); ^ In file included from objdir/gfx/ipc/Unified_cpp_gfx_ipc0.cpp:56: gfx/ipc/GPUProcessManager.cpp:328:5: error: use of undeclared identifier 'SprintfLiteral' SprintfLiteral(disableMessage, "GPU process disabled after %d attempts", ^ 2 warnings and 1 error generated.
Comment on attachment 8810963 [details] Bug 1317757 - Explicitly include header for SprintfLiteral(). https://reviewboard.mozilla.org/r/93226/#review93218
Attachment #8810963 - Flags: review?(milan) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d7f47206d367 Explicitly include header for SprintfLiteral(). r=milan
You need to log in before you can comment on or make changes to this bug.