1317769 - test_blocklist_signatures.js can't run on an artifact build

Status: RESOLVED DUPLICATE of bug 1330421

(Firefox Build System :: General, defect)

Description

[Ethan Glasser-Camp (:glasserc)]

I am testing some changes to the Kinto library and wanted to run services/common/tests/unit/test_blocklist_signatures.js to see if my changes were OK. However, I got the error message "mozilla-central/objdir-frontend-debug-artifact/_tests/xpcshell/services/common/tests/unit/test_blocklist_signatures/collection_signing_ee.pem does not exist". And indeed it didn't. In that directory, I only saw symlinks to files like collection_signing_ee.pem.certspec.

This was with an artifact build based on mozilla-central tip (pulled as of 2016-11-14 or so). I suspected that this might be due to this being an artifact build rather than a full build. I didn't want to verify this by spending 20 minutes building from scratch :)

I spoke to :keeler on #security, who told me that "creating that file happens as part of building tests, so that might not work with artifact builds. However, you might be able to create it by running security/manager/ssl/tests/unit/pycert.py on the certspec file". I was able to do that using a command like:

objdir-frontend-debug-artifact/_virtualenv/bin/python security/manager/ssl/tests/unit/pycert.py < objdir-frontend-debug-artifact/_tests/xpcshell/services/common/tests/unit/test_blocklist_signatures/collection_signing_root.pem.certspec   > objdir-frontend-debug-artifact/_tests/xpcshell/services/common/tests/unit/test_blocklist_signatures/collection_signing_root.pem

I did this for each certspec file, and then running the test succeeded.

It seems like tests are something that ought to work even with artifact builds, so :keeler asked me to file a bug.

Comment 1

[Gregory Szorc [:gps]]

pycert.py is hooked up to GENERATED_FILES and TEST_HARNESS_FILES via build/test_templates.mozbuild. So I guess we're dropping those targets from artifact builds or we're never picking up the moz.build files with the GeneratedTestCertificate and GenerateTestKey objects for whatever reason?

Comment 2

[Chris Manchester (limited bugmail, email directly)]

These were skipped on artifact builds in bug 1227248. We've expanded the use cases supported by artifact builds quite a bit since then.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

The patches I'm working on for bug 1330421 allow me to run this test from an artifact build.