Closed Bug 1317771 Opened 8 years ago Closed 8 years ago

remove all code #ifdef'd on SPS_STANDALONE

Categories

(Core :: Gecko Profiler, defect)

Product:
Core
Component:
Gecko Profiler
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: froydnj, Assigned: n.nethercote)

References

Details

Attachments

(2 files)

(part 1) - Remove SPS_STANDALONE
56.62 KB, patch
mstange
: review+
Details | Diff | Splinter Review
(part 2) - Remove SPS_STANDALONE
7.75 KB, patch
mstange
: review+
Details | Diff | Splinter Review
I don't think we're actually testing a SPS_STANDALONE build configuration, so we're sure to break it at some point...if it isn't broken already. Making this change would also remove a decent amount of clutter.
I like deleting code!
Assignee: nobody → n.nethercote
This patch removes all the |#ifndef SPS_STANDALONE| guards.
Attachment #8827714 - Flags: review?(mstange)
This patch removes all the |#ifdef SPS_STANDALONE| blocks.
Attachment #8827715 - Flags: review?(mstange)
Attachment #8827714 - Flags: review?(mstange) → review+
Attachment #8827715 - Flags: review?(mstange) → review+
https://hg.mozilla.org/mozilla-central/rev/450a6f20a957 https://hg.mozilla.org/mozilla-central/rev/fdfd2c64c77c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: