remove all code #ifdef'd on SPS_STANDALONE

RESOLVED FIXED in Firefox 53

Status

()

Core
Gecko Profiler
RESOLVED FIXED
7 months ago
5 months ago

People

(Reporter: froydnj, Assigned: njn)

Tracking

Trunk
mozilla53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(2 attachments)

(Reporter)

Description

7 months ago
I don't think we're actually testing a SPS_STANDALONE build configuration, so we're sure to break it at some point...if it isn't broken already.  Making this change would also remove a decent amount of clutter.
Blocks: 1328363
(Assignee)

Comment 1

5 months ago
I like deleting code!
Assignee: nobody → n.nethercote
(Assignee)

Comment 2

5 months ago
Created attachment 8827714 [details] [diff] [review]
(part 1) - Remove SPS_STANDALONE

This patch removes all the |#ifndef SPS_STANDALONE| guards.
Attachment #8827714 - Flags: review?(mstange)
(Assignee)

Comment 3

5 months ago
Created attachment 8827715 [details] [diff] [review]
(part 2) - Remove SPS_STANDALONE

This patch removes all the |#ifdef SPS_STANDALONE| blocks.
Attachment #8827715 - Flags: review?(mstange)
Attachment #8827714 - Flags: review?(mstange) → review+
Attachment #8827715 - Flags: review?(mstange) → review+
(Assignee)

Comment 4

5 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/450a6f20a957ebfadde152595142421c8202d896
Bug 1317771 (part 1) - Remove SPS_STANDALONE. r=mstange.

https://hg.mozilla.org/integration/mozilla-inbound/rev/fdfd2c64c77cdc3458660e3338e9e3c952f6f535
Bug 1317771 (part 2) - Remove SPS_STANDALONE. r=mstange.

Comment 5

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/450a6f20a957
https://hg.mozilla.org/mozilla-central/rev/fdfd2c64c77c
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.