1317976 - enable performance counters for taskcluster windows builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Rob Thijssen [:grenade (EET/UTC+0300)]]

so that we can generate reports like this one (for bb win builds): https://treeherder.mozilla.org/perf.html#/graphs?series=%5Bmozilla-inbound,4fbfc3c875f4dd781769fd461689a1cbb88c704f,1,2%5D&series=%5Bmozilla-inbound,da9415dda623287ef4a2b0d749e9a773d606e1d5,1,2%5D&series=%5Bmozilla-inbound,592b8602a8902b60c93afd6d953ad3a629cc895c,1,2%5D

from irc:
15:17 W<wlach> grenade|afk: should be pretty simple, you just need to add a line called PERFHERDER_DATA to the logfile for the job with information on timings. grep for that string in m-c and you should find examples (you should probably model after what we do for other builds)

Comment 1

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Attachment: Bug 1317976 - enable generate-build-stats on tc win builds

Review commit: https://reviewboard.mozilla.org/r/95432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/95432/

Comment 2

[William Lachance (:wlach)]

Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds

I don't think I'm the right person to review this, there isn't anything perfherder-specific here. Redirecting to :ted (I'm not sure if he's the right person either, but at least he might know...)

Comment 3

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds

gps: if possible could you review this patch to enable performance counters on tc windows builds?

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds

https://reviewboard.mozilla.org/r/95432/#review97486

This looks good, thanks for fixing it! (I wish I'd had these stats enabled for comparing sccache build times.)

::: testing/mozharness/mozharness/mozilla/building/buildbase.py:1931
(Diff revision 1)
>                      packageName = name
>                      break
> +                # if we are not using MOZ_SIMPLE_PACKAGE_NAME, check for the
> +                # default package naming convention
> +                name = 'firefox-{}.en-US.{}.{}'.format(
> +                    self.get_firefox_version(), c.get('platform'), ext)

Minor issue, but maybe hoist the `get_firefox_version()` call out of the loop?

Comment 5

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95432/diff/1-2/

Comment 6

[Rob Thijssen [:grenade (EET/UTC+0300)]]

Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/95432/diff/2-3/

Comment 7

[Rob Thijssen [:grenade (EET/UTC+0300)]]

implemented change to move `get_firefox_version()` out of the loop and rebased against tip (some filenames had changed).

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8814161 [details]
Bug 1317976 - enable generate-build-stats on tc win builds

https://reviewboard.mozilla.org/r/95432/#review97552

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d2d2fdac6c7
enable generate-build-stats on tc win builds r=gps,ted

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/6d2d2fdac6c7