Closed
Bug 1318000
Opened 8 years ago
Closed 8 years ago
Convert some code in image/ to C++11
Categories
(Developer Infrastructure :: Source Code Analysis, defect)
Developer Infrastructure
Source Code Analysis
Tracking
(firefox53 fixed)
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: andi, Assigned: andi)
References
Details
Attachments
(3 files)
Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like: - auto variables declarations - default CTORS and DTORS - using new range loop operators
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Attachment #8811305 -
Flags: review?(jmuizelaar)
Attachment #8811306 -
Flags: review?(jmuizelaar)
Attachment #8811307 -
Flags: review?(jmuizelaar)
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8811306 [details] Bug 1318000 - Replace default bodies of special member functions with = default; in image/. https://reviewboard.mozilla.org/r/93456/#review93918
Attachment #8811306 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8811307 [details] Bug 1318000 - Use C++11's override and remove virtual where applicable in image/. https://reviewboard.mozilla.org/r/93458/#review93920
Attachment #8811307 -
Flags: review?(jmuizelaar) → review+
|
|
||
Comment 6•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8811305 [details] Bug 1318000 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in image/. https://reviewboard.mozilla.org/r/93454/#review93922
Attachment #8811305 -
Flags: review?(jmuizelaar) → review+
Pushed by bpostelnicu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7505957987ce Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in image/. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/f6568e8ff979 Replace default bodies of special member functions with = default; in image/. r=jrmuizel https://hg.mozilla.org/integration/autoland/rev/21f52dfa70b9 Use C++11's override and remove virtual where applicable in image/. r=jrmuizel
|
||
Comment 8•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7505957987ce https://hg.mozilla.org/mozilla-central/rev/f6568e8ff979 https://hg.mozilla.org/mozilla-central/rev/21f52dfa70b9
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
https://hg.mozilla.org/mozilla-central/rev/7505957987ce https://hg.mozilla.org/mozilla-central/rev/f6568e8ff979 https://hg.mozilla.org/mozilla-central/rev/21f52dfa70b9
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•