Convert some code in image/ to C++11

RESOLVED FIXED in Firefox 53

Status

defect
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: andi, Assigned: andi)

Tracking

Trunk
mozilla53
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(3 attachments)

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators
Attachment #8811305 - Flags: review?(jmuizelaar)
Attachment #8811306 - Flags: review?(jmuizelaar)
Attachment #8811307 - Flags: review?(jmuizelaar)
Comment on attachment 8811306 [details]
Bug 1318000 - Replace default bodies of special member functions with = default; in image/.

https://reviewboard.mozilla.org/r/93456/#review93918
Attachment #8811306 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8811307 [details]
Bug 1318000 - Use C++11's override and remove virtual where applicable in image/.

https://reviewboard.mozilla.org/r/93458/#review93920
Attachment #8811307 - Flags: review?(jmuizelaar) → review+
Comment on attachment 8811305 [details]
Bug 1318000 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in image/.

https://reviewboard.mozilla.org/r/93454/#review93922
Attachment #8811305 - Flags: review?(jmuizelaar) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7505957987ce
Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in image/. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/f6568e8ff979
Replace default bodies of special member functions with = default; in image/. r=jrmuizel
https://hg.mozilla.org/integration/autoland/rev/21f52dfa70b9
Use C++11's override and remove virtual where applicable in image/. r=jrmuizel
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.