Closed Bug 1318001 Opened 3 years ago Closed 3 years ago

Autophone - mozdevice - adb*.py - properly split lines from shell output.

Categories

(Testing :: Autophone, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: bc, Assigned: bc)

References

Details

Attachments

(3 files, 2 obsolete files)

Versions of Android prior to 7 use DOS line endings with carriage returns \r. adb*.py has several places where we split output from a shell command into lines via '...'.split('\r'). This does not work when the output uses newlines \n. In addition, we have at least one location where we use '...'.split('\r\n') which may not be what is intended.
Attached patch autophone bug-1318001-v1.patch (obsolete) — Splinter Review
Attachment #8811308 - Flags: review?(gbrown)
Attached patch mozdevice bug-1318001-v1.patch (obsolete) — Splinter Review
Attachment #8811311 - Flags: review?(gbrown)
with more splitlines goodness thanks to gbrown.
Attachment #8811308 - Attachment is obsolete: true
Attachment #8811308 - Flags: review?(gbrown)
Attachment #8811376 - Flags: review?(gbrown)
Attachment #8811311 - Attachment is obsolete: true
Attachment #8811311 - Flags: review?(gbrown)
Attachment #8811377 - Flags: review?(gbrown)
Attachment #8811376 - Flags: review?(gbrown) → review+
Attachment #8811377 - Flags: review?(gbrown) → review+
Follow up autophone only patch to fix a split in utils.py
Attachment #8811382 - Flags: review?(gbrown)
Attachment #8811382 - Flags: review?(gbrown) → review+
Pushed by bclary@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eee080a43674
Autophone - mozdevice - adb*.py - properly split lines from shell output, r=gbrown.
https://hg.mozilla.org/mozilla-central/rev/eee080a43674
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
deployed 2016-11-18 ~10:00 AM
You need to log in before you can comment on or make changes to this bug.