1318001 - Autophone - mozdevice - adb*.py - properly split lines from shell output.

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Versions of Android prior to 7 use DOS line endings with carriage returns \r. adb*.py has several places where we split output from a shell command into lines via '...'.split('\r'). This does not work when the output uses newlines \n. In addition, we have at least one location where we use '...'.split('\r\n') which may not be what is intended.

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: autophone bug-1318001-v1.patch

Comment 2

[Bob Clary [:bc] (inactive)]

Attachment: mozdevice bug-1318001-v1.patch

Comment 3

[Bob Clary [:bc] (inactive)]

Example run locally with Nexus 6P and Pixel with this patch and patches from bug 1245347 and bug 1317426 :
https://treeherder.allizom.org/#/jobs?repo=autoland&revision=2b4c107f00d2f42d305e00f97fce69eaf1dcb44a&filter-searchStr=autophone

Comment 4

[Bob Clary [:bc] (inactive)]

Attachment: autophone bug-1318001-v2.patch

with more splitlines goodness thanks to gbrown.

Comment 5

[Bob Clary [:bc] (inactive)]

Attachment: mozdevice bug-1318001-v2.patch

Comment 6

[Bob Clary [:bc] (inactive)]

Attachment: bug-1318001-utils.patch

Follow up autophone only patch to fix a split in utils.py

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eee080a43674
Autophone - mozdevice - adb*.py - properly split lines from shell output, r=gbrown.

Comment 8

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/53d6671d0a54233f7ce778c324287475c8482bc4
https://github.com/mozilla/autophone/commit/17276d3d7c5e08da3c5ae303388891e64f5fe4a1

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/eee080a43674

Comment 10

[Bob Clary [:bc] (inactive)]

deployed 2016-11-18 ~10:00 AM

Comment 11

[areya]

https://hg.mozilla.org/mozilla-central/rev/eee080a43674