Can't zoom large PNG

RESOLVED FIXED in Firefox 51

Status

()

Core
ImageLib
P3
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: Alexandre Folle de Menezes, Assigned: milan)

Tracking

({regression})

51 Branch
mozilla53
x86
Windows 7
regression
Points:
---

Firefox Tracking Flags

(firefox50 unaffected, firefox51 fixed, firefox52 fixed, firefox53 fixed)

Details

(Whiteboard: [gfx-noted], URL)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
I can load the following image fine on released FFox 50, and when I zoom in it displays fine:
http://winapp2.com/dropbox/2016-11-14_151443.png

If I do this on today's Nightly (16/nov/16), it loads the image but hangs when I try to zoom in.
(Reporter)

Updated

11 months ago
This was caused by part 2 of bug 1299164, specifically:
http://searchfox.org/mozilla-central/diff/e13a243ec156ea7d1b07920dc38f7d7c92989909/gfx/2d/Factory.cpp#812
Blocks: 1299164
Assignee: nobody → milan
Priority: -- → P3
Whiteboard: [gfx-noted]
Version: 53 Branch → 51 Branch
I'm thinking that after bug 1224254 (which makes ~500M the maximum allocation size), we can increase the limit on each dimension; perhaps even remove it?  I understand pixman has issues with > 32k when printing.

A 500M allocation size would let us have approximately a 32k x 4k image - it seems that allowing 128k x 1k should not be much worse, except for the short overflow, so it shouldn't be done lightly.
See Also: → bug 944579, bug 1224254
status-firefox51: --- → affected
status-firefox52: --- → affected
Keywords: regression
Flags: needinfo?(milan)

Updated

11 months ago
status-firefox50: --- → unaffected
Comment hidden (mozreview-request)

Comment 4

11 months ago
mozreview-review
Comment on attachment 8812828 [details]
Bug 1318007: When the surface is already allocated, just check for non-positive dimensions.

https://reviewboard.mozilla.org/r/94416/#review94646
Attachment #8812828 - Flags: review?(aosmond) → review+

Comment 5

11 months ago
Pushed by msreckovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/86f37704bbf8
When the surface is already allocated, just check for non-positive dimensions. r=aosmond
Comment on attachment 8812828 [details]
Bug 1318007: When the surface is already allocated, just check for non-positive dimensions.

Approval Request Comment
[Feature/regressing bug #]: bug 1299164 (in 51)
[User impact if declined]: Large images (>32k in one dimension) are not drawn
[Describe test coverage new/current, TreeHerder]: There may be more tests in bug 591822
[Risks and why]: 
[String/UUID change made/needed]:

This is a partial revert of the patch in bug 1299164 that regressed this.
Flags: needinfo?(milan)
Attachment #8812828 - Flags: approval-mozilla-beta?
Attachment #8812828 - Flags: approval-mozilla-aurora?

Comment 7

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/86f37704bbf8
Status: NEW → RESOLVED
Last Resolved: 11 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Comment on attachment 8812828 [details]
Bug 1318007: When the surface is already allocated, just check for non-positive dimensions.

Fix a large PNG zooming issue. Beta51+ and Aurora52+. Should be in 51 beta 3.
Attachment #8812828 - Flags: approval-mozilla-beta?
Attachment #8812828 - Flags: approval-mozilla-beta+
Attachment #8812828 - Flags: approval-mozilla-aurora?
Attachment #8812828 - Flags: approval-mozilla-aurora+

Comment 9

11 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/7c429d5fab4b
status-firefox52: affected → fixed

Comment 10

11 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/0f6a643ab177
status-firefox51: affected → fixed
You need to log in before you can comment on or make changes to this bug.