1318007 - Can't zoom large PNG

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect, P3)

Description

[Alexandre Folle de Menezes]

I can load the following image fine on released FFox 50, and when I zoom in it displays fine:
http://winapp2.com/dropbox/2016-11-14_151443.png

If I do this on today's Nightly (16/nov/16), it loads the image but hangs when I try to zoom in.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

This was caused by part 2 of bug 1299164, specifically:
http://searchfox.org/mozilla-central/diff/e13a243ec156ea7d1b07920dc38f7d7c92989909/gfx/2d/Factory.cpp#812

Comment 2

[Milan Sreckovic [:milan] (needinfo for best results)]

I'm thinking that after bug 1224254 (which makes ~500M the maximum allocation size), we can increase the limit on each dimension; perhaps even remove it?  I understand pixman has issues with > 32k when printing.

A 500M allocation size would let us have approximately a 32k x 4k image - it seems that allowing 128k x 1k should not be much worse, except for the short overflow, so it shouldn't be done lightly.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

Attachment: Bug 1318007: When the surface is already allocated, just check for non-positive dimensions.

Review commit: https://reviewboard.mozilla.org/r/94416/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94416/

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 8812828 [details]
Bug 1318007: When the surface is already allocated, just check for non-positive dimensions.

https://reviewboard.mozilla.org/r/94416/#review94646

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86f37704bbf8
When the surface is already allocated, just check for non-positive dimensions. r=aosmond

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment on attachment 8812828 [details]
Bug 1318007: When the surface is already allocated, just check for non-positive dimensions.

Approval Request Comment
[Feature/regressing bug #]: bug 1299164 (in 51)
[User impact if declined]: Large images (>32k in one dimension) are not drawn
[Describe test coverage new/current, TreeHerder]: There may be more tests in bug 591822
[Risks and why]: 
[String/UUID change made/needed]:

This is a partial revert of the patch in bug 1299164 that regressed this.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/86f37704bbf8

Comment 8

[Gerry Chang [:gchang]]

Comment on attachment 8812828 [details]
Bug 1318007: When the surface is already allocated, just check for non-positive dimensions.

Fix a large PNG zooming issue. Beta51+ and Aurora52+. Should be in 51 beta 3.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7c429d5fab4b

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/0f6a643ab177