Enable thread-safe statics on Windows builds after XP support is dropped

RESOLVED FIXED in Firefox 53

Status

()

Core
Build Config
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: dmajor, Assigned: froydnj)

Tracking

unspecified
mozilla53
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
Once XP builds no longer need to work, we can back out https://hg.mozilla.org/mozilla-central/rev/fc169db1ce4d
(Assignee)

Comment 1

11 months ago
Test run for the backout, just to make sure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8e3cce7ad4aab255cc398c334ed8e21c58e2953
(Assignee)

Comment 2

11 months ago
Created attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

This change effectively backs out bug 1204752.  Since we no longer need
to support XP, we can enable thread-safe-statics.
Attachment #8816568 - Flags: review?(dmajor)
(Assignee)

Updated

11 months ago
Assignee: nobody → nfroyd
(Reporter)

Comment 3

11 months ago
Comment on attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

Looks great to me, but I don't want to bypass the build peers on this...
Attachment #8816568 - Flags: review?(dmajor) → review?(mh+mozilla)

Comment 4

11 months ago
Comment on attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

The patch is fine, but it effectively needs the xp-eol bug to actually be closed first.
Attachment #8816568 - Flags: review?(mh+mozilla)
(Assignee)

Comment 5

11 months ago
(In reply to Mike Hommey [:glandium] from comment #4)
> The patch is fine, but it effectively needs the xp-eol bug to actually be
> closed first.

The xp-eol bug is blocked by things like "message this subset of users" and "stop updating X versions", which aren't relevant to this bug.  We've already turned off XP testing on (inbound, central), we've stopped installers for 53 from working on XP, we've stopped issuing updates, etc. etc.  From my perspective, it seems like 53 can already start taking patches to drop XP support...what else do you think needs to happen for this patch to land?
Flags: needinfo?(mh+mozilla)

Comment 6

11 months ago
At the very least, we should first stop building with -SUBSYSTEM:*,5.01
Flags: needinfo?(mh+mozilla)

Updated

11 months ago
Depends on: 1322646

Updated

11 months ago
No longer depends on: 1130266

Comment 7

11 months ago
(In reply to Mike Hommey [:glandium] from comment #6)
> At the very least, we should first stop building with -SUBSYSTEM:*,5.01

I have filed bug 1322646 for this.
(Assignee)

Comment 8

10 months ago
Comment on attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

Re-asking for review now that we enable the proper subsystem compilation flags.
Attachment #8816568 - Flags: review?(mh+mozilla)

Updated

10 months ago
Attachment #8816568 - Flags: review?(mh+mozilla) → review+

Comment 9

10 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9dacbeb8bd
re-enable thread-safe statics on Windows builds; r=glandium

Comment 10

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9b9dacbeb8bd
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.