Closed Bug 1318025 Opened 3 years ago Closed 3 years ago

Enable thread-safe statics on Windows builds after XP support is dropped

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: dmajor, Assigned: froydnj)

References

Details

Attachments

(1 file)

Once XP builds no longer need to work, we can back out https://hg.mozilla.org/mozilla-central/rev/fc169db1ce4d
This change effectively backs out bug 1204752.  Since we no longer need
to support XP, we can enable thread-safe-statics.
Attachment #8816568 - Flags: review?(dmajor)
Assignee: nobody → nfroyd
Comment on attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

Looks great to me, but I don't want to bypass the build peers on this...
Attachment #8816568 - Flags: review?(dmajor) → review?(mh+mozilla)
Comment on attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

The patch is fine, but it effectively needs the xp-eol bug to actually be closed first.
Attachment #8816568 - Flags: review?(mh+mozilla)
(In reply to Mike Hommey [:glandium] from comment #4)
> The patch is fine, but it effectively needs the xp-eol bug to actually be
> closed first.

The xp-eol bug is blocked by things like "message this subset of users" and "stop updating X versions", which aren't relevant to this bug.  We've already turned off XP testing on (inbound, central), we've stopped installers for 53 from working on XP, we've stopped issuing updates, etc. etc.  From my perspective, it seems like 53 can already start taking patches to drop XP support...what else do you think needs to happen for this patch to land?
Flags: needinfo?(mh+mozilla)
At the very least, we should first stop building with -SUBSYSTEM:*,5.01
Flags: needinfo?(mh+mozilla)
Depends on: 1322646
No longer depends on: xp-eol
(In reply to Mike Hommey [:glandium] from comment #6)
> At the very least, we should first stop building with -SUBSYSTEM:*,5.01

I have filed bug 1322646 for this.
Comment on attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

Re-asking for review now that we enable the proper subsystem compilation flags.
Attachment #8816568 - Flags: review?(mh+mozilla)
Attachment #8816568 - Flags: review?(mh+mozilla) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9dacbeb8bd
re-enable thread-safe statics on Windows builds; r=glandium
https://hg.mozilla.org/mozilla-central/rev/9b9dacbeb8bd
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.