1318025 - Enable thread-safe statics on Windows builds after XP support is dropped

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[(Away)]

Once XP builds no longer need to work, we can back out https://hg.mozilla.org/mozilla-central/rev/fc169db1ce4d

Comment 1

[Nathan Froyd [:froydnj]]

Test run for the backout, just to make sure:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8e3cce7ad4aab255cc398c334ed8e21c58e2953

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: re-enable thread-safe statics on Windows builds

This change effectively backs out bug 1204752.  Since we no longer need
to support XP, we can enable thread-safe-statics.

Comment 3

[(Away)]

Comment on attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

Looks great to me, but I don't want to bypass the build peers on this...

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

The patch is fine, but it effectively needs the xp-eol bug to actually be closed first.

Comment 5

[Nathan Froyd [:froydnj]]

(In reply to Mike Hommey [:glandium] from comment #4)
> The patch is fine, but it effectively needs the xp-eol bug to actually be
> closed first.

The xp-eol bug is blocked by things like "message this subset of users" and "stop updating X versions", which aren't relevant to this bug.  We've already turned off XP testing on (inbound, central), we've stopped installers for 53 from working on XP, we've stopped issuing updates, etc. etc.  From my perspective, it seems like 53 can already start taking patches to drop XP support...what else do you think needs to happen for this patch to land?

Comment 6

[Mike Hommey [:glandium]]

At the very least, we should first stop building with -SUBSYSTEM:*,5.01

Comment 7

[Masatoshi Kimura [:emk]]

(In reply to Mike Hommey [:glandium] from comment #6)
> At the very least, we should first stop building with -SUBSYSTEM:*,5.01

I have filed bug 1322646 for this.

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8816568 [details] [diff] [review]
re-enable thread-safe statics on Windows builds

Re-asking for review now that we enable the proper subsystem compilation flags.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9b9dacbeb8bd
re-enable thread-safe statics on Windows builds; r=glandium

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9b9dacbeb8bd