1318029 - LongStringActor doesn't work in storage inspector with long strings

Status: RESOLVED FIXED

(DevTools :: Framework, defect, P3)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

When bug 1276339 is fixed we need to work out why the LongStringActor doesn't work in devtools/server/actors/storage.js.

STR:

1. Search for this bug number in devtools/server/actors/storage.js and remove the trimming of DB entry values.
2. On about:home open the storage inspector and expand the indexedDB tree for that page.

Actual:
There is a 25,000+ character snippet contained in indexedDB for this page. When the objectStore is expanded and the long string is encountered the following exception is displayed and the objectStore appears empty:

console.error:
  Message: TypeError: type.frontClass is not a constructor
  Stack:
    types.addActorType/type<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:278:17
.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/specs/string.js:86:12
types.addNullableType/<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:329:14
types.addDictType/<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:220:23
types.addNullableType/<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:329:14
types.addArrayType/<.read/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:197:39
types.addArrayType/<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:197:23
types.addDictType/<.read@resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/shared/protocol.js:220:23

Expected:
The object stores should be shown and no error should be thrown.

As part of fixing this issue we should resolve the fixme in devtools/server/actors/storage.js.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1318029 - [devtools] Remove substring of long values in storage actor. r=ochameau.

It looks like something that was needed at some point but isn't anymore, as it
works fine without it.
Test cases are added for long indexedDb and webExtensionStorage values.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f856203f7df
[devtools] Remove substring of long values in storage actor. r=ochameau.

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/2f856203f7df