Closed Bug 1318044 Opened 5 years ago Closed 5 years ago

BUILDSTATUS messages printed when building with clang + color

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox50 unaffected, firefox51 unaffected, firefox52 unaffected, firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- unaffected
firefox53 --- fixed

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

(Keywords: regression)

Attachments

(2 files)

This is a regression from bug 1171610.

When building with Clang with color enabled, sometimes the output contains "BUILDSTATUS *" messages. These messages are supposed to be slurped away by the build output monitor running in the mach process. However, that isn't working. The likely culprit is terminal control bytes related to coloring.

As was observed in the development of bug 1171610, Clang doesn't "unset" its control codes at the end of every line (GCC does). I thought this was limited to the mach time prefixes being colored incorrectly. I guess it is interfering with BUILDSTATUS output parsing as well :/
Attached image Screenshot
(In reply to Gregory Szorc [:gps] from comment #0)
> Clang doesn't "unset" its
> control codes at the end of every line (GCC does).

This is likely also why I see timestamps showing up "brighter" occasionally (see attached screenshot).
Assignee: nobody → gps
Status: NEW → ASSIGNED
Comment on attachment 8818050 [details]
Bug 1318044 - Issue sgr0 after printing every line;

https://reviewboard.mozilla.org/r/98170/#review99962

WFM!
Attachment #8818050 - Flags: review+
Comment on attachment 8818050 [details]
Bug 1318044 - Issue sgr0 after printing every line;

Flip glandium's r+ flag, since mozreview didn't notice my r+.
Attachment #8818050 - Flags: review?(mh+mozilla) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b0dd252edd7
Issue sgr0 after printing every line; r=froydnj
https://hg.mozilla.org/mozilla-central/rev/3b0dd252edd7
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Blocks: 1325181
Version: unspecified → Trunk
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.