Closed Bug 1318099 Opened 3 years ago Closed 3 years ago

Stop running artifact builds on the graphics project branch

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla53

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

The artifact builds look for push heads on specific candidate branches [1]. On the graphics branch we are pushing code which isn't found on those candidate branches. so those artifact jobs just fail. See [2] for an example.

I'd like to disable the artifact job (there's actually only one) on the graphics branch. I wrote a patch and verified it has the desired effect by using |mach taskgraph decision| with a lot of parameters that I pulled from a parameters.yml file on the graphics branch.

[1] http://searchfox.org/mozilla-central/rev/efcb1644e49c36445e75d89b434fdf4c84832c84/python/mozbuild/mozbuild/artifacts.py#109
[2] https://treeherder.mozilla.org/#/jobs?repo=graphics&revision=cc3d0823289f64804fce57ac51a03b0b17d0189e&selectedJob=5800
Comment on attachment 8811450 [details]
Bug 1318099 - Disable artifact build tasks on the graphics branch.

https://reviewboard.mozilla.org/r/93532/#review94042
Attachment #8811450 - Flags: review?(dustin) → review+
(In reply to Dustin J. Mitchell [:dustin] from comment #2)
> There are easier ways to test! :)
>  
> http://gecko.readthedocs.io/en/latest/taskcluster/taskcluster/how-tos.
> html#hacking-task-graphs

I tried using |mach taskgraph target| but it didn't seem to exercise the same code, unfortunately. In particular it doesn't go through the decision.py code. I've been using those other subcommands for verifying new tasks that I've been adding to the graphics project branch, though.

Thanks for the review!
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0b955dfca151
Disable artifact build tasks on the graphics branch. r=dustin
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/f76168493c67
Disable artifact build tasks on the graphics branch: add empty line to make flake8 happy. r=flake8-fix
https://hg.mozilla.org/mozilla-central/rev/0b955dfca151
https://hg.mozilla.org/mozilla-central/rev/f76168493c67
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.