1318113 - Use shared memory to return the reftest snapshot

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Markus Stange [:mstange]]

Using an array of uint8_t as an outparam is probably not the best for performance.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Yup, thanks! I was going to do this next, but thanks for taking it since I'm on PTO for a while.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use shared memory to return the reftest snapshot

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use shared memory to return the reftest snapshot

Comment 4

[Nicolas Silva [:nical]]

Comment on attachment 8813943 [details] [diff] [review]
patch - Use shared memory to return the reftest snapshot

Review of attachment 8813943 [details] [diff] [review]:
-----------------------------------------------------------------

It would be nice to use TextureClient for this. The existence of the equivalent AllocSurfaceDescriptor in the ShadowLayers is really an artifact of the old pre-TextureClient days (when every texture was allocated through this API) which we didn't take the time to remove entirely. I would prefer that we avoid adding more of it. Using TextureClient for snapshot would make it easier for us to avoid reading them back if the result is only used on the GPU (which is arguably not what you are after for reftests, but the use case has come up a few times in the past).

Comment 5

[Sotaro Ikeda [:sotaro]]

I am going to try to use TextureClient here.

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use shared memory to return the reftest snapshot

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use BufferTexture to return the reftest snapshot

The patch use BufferTexture to take snapshot. The patch limits a type of Texture to BufferTexture to simplify the patch.

Comment 8

[Nicolas Silva [:nical]]

Comment on attachment 8814330 [details] [diff] [review]
patch - Use BufferTexture to return the reftest snapshot

Review of attachment 8814330 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use BufferTexture to return the reftest snapshot

Rebased.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Use BufferTexture to return the reftest snapshot

Fixed assert check.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/fa40a7b4f05f
Use BufferTexture to return the reftest snapshot r=nical?