Closed Bug 1318113 Opened 3 years ago Closed 3 years ago

Use shared memory to return the reftest snapshot

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox53 --- affected

People

(Reporter: mstange, Assigned: sotaro)

References

Details

Attachments

(1 file, 5 obsolete files)

Using an array of uint8_t as an outparam is probably not the best for performance.
Blocks: webrender
Assignee: nobody → sotaro.ikeda.g
Yup, thanks! I was going to do this next, but thanks for taking it since I'm on PTO for a while.
Depends on: 1319303
Attachment #8813942 - Attachment is obsolete: true
Attachment #8813943 - Flags: review?(nical.bugzilla)
Comment on attachment 8813943 [details] [diff] [review]
patch - Use shared memory to return the reftest snapshot

Review of attachment 8813943 [details] [diff] [review]:
-----------------------------------------------------------------

It would be nice to use TextureClient for this. The existence of the equivalent AllocSurfaceDescriptor in the ShadowLayers is really an artifact of the old pre-TextureClient days (when every texture was allocated through this API) which we didn't take the time to remove entirely. I would prefer that we avoid adding more of it. Using TextureClient for snapshot would make it easier for us to avoid reading them back if the result is only used on the GPU (which is arguably not what you are after for reftests, but the use case has come up a few times in the past).
I am going to try to use TextureClient here.
Attachment #8813943 - Attachment is obsolete: true
Attachment #8813943 - Flags: review?(nical.bugzilla)
The patch use BufferTexture to take snapshot. The patch limits a type of Texture to BufferTexture to simplify the patch.
Attachment #8814330 - Flags: feedback?(nical.bugzilla)
Comment on attachment 8814330 [details] [diff] [review]
patch - Use BufferTexture to return the reftest snapshot

Review of attachment 8814330 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!
Attachment #8814330 - Flags: feedback?(nical.bugzilla) → feedback+
Attachment #8814297 - Attachment is obsolete: true
Rebased.
Attachment #8814330 - Attachment is obsolete: true
Fixed assert check.
Attachment #8814758 - Attachment is obsolete: true
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/fa40a7b4f05f
Use BufferTexture to return the reftest snapshot r=nical?
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.