Closed Bug 1318132 Opened 3 years ago Closed 3 years ago

Coverity issue in CamerasChild

Categories

(Core :: WebRTC: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: jib, Assigned: jib)

Details

Attachments

(1 file)

*** CID 1394282:  Memory - illegal accesses  (RETURN_LOCAL)
/dom/media/systemservices/CamerasChild.cpp: 409 in mozilla::camera::CamerasChild::GetCaptureDevice(mozilla::camera::CaptureEngine, unsigned int, char *, unsigned int, char *, unsigned int, bool *)()
403         base::strlcpy(unique_idUTF8, mReplyDeviceID.get(), unique_idUTF8Length);
404         if (scary) {
405           *scary = mReplyScary;
406         }
407         LOG(("Got %s name %s id", device_nameUTF8, unique_idUTF8));
408       }

>>>     CID 1394282:  Memory - illegal accesses  (RETURN_LOCAL)
>>>     Using "dispatcher.ReturnValue()", which points to an out-of-scope temporary variable of type "int const".

409       return dispatcher.ReturnValue();
410     }
411     
412     bool
413     CamerasChild::RecvReplyGetCaptureDevice(const nsCString& device_name,
414                                             const nsCString& device_id,
Comment on attachment 8811482 [details]
Bug 1318132 - Fix CamerasChild helper to return by value instead of out-of-scope reference (Coverity)

https://reviewboard.mozilla.org/r/93598/#review93676
Attachment #8811482 - Flags: review?(rjesup) → review+
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f0f06d912b18
Fix CamerasChild helper to return by value instead of out-of-scope reference (Coverity) r=jesup
https://hg.mozilla.org/mozilla-central/rev/f0f06d912b18
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.