1318132 - Coverity issue in CamerasChild

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect)

Description

[Back Tuesday [:jib]]

*** CID 1394282:  Memory - illegal accesses  (RETURN_LOCAL)
/dom/media/systemservices/CamerasChild.cpp: 409 in mozilla::camera::CamerasChild::GetCaptureDevice(mozilla::camera::CaptureEngine, unsigned int, char *, unsigned int, char *, unsigned int, bool *)()
403         base::strlcpy(unique_idUTF8, mReplyDeviceID.get(), unique_idUTF8Length);
404         if (scary) {
405           *scary = mReplyScary;
406         }
407         LOG(("Got %s name %s id", device_nameUTF8, unique_idUTF8));
408       }

>>>     CID 1394282:  Memory - illegal accesses  (RETURN_LOCAL)
>>>     Using "dispatcher.ReturnValue()", which points to an out-of-scope temporary variable of type "int const".

409       return dispatcher.ReturnValue();
410     }
411     
412     bool
413     CamerasChild::RecvReplyGetCaptureDevice(const nsCString& device_name,
414                                             const nsCString& device_id,

Comment 1

[Back Tuesday [:jib]]

Attachment: Bug 1318132 - Fix CamerasChild helper to return by value instead of out-of-scope reference (Coverity)

Review commit: https://reviewboard.mozilla.org/r/93598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93598/

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8811482 [details]
Bug 1318132 - Fix CamerasChild helper to return by value instead of out-of-scope reference (Coverity)

https://reviewboard.mozilla.org/r/93598/#review93676

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0f06d912b18
Fix CamerasChild helper to return by value instead of out-of-scope reference (Coverity) r=jesup

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/f0f06d912b18

Comment 5

[areya]

https://hg.mozilla.org/mozilla-central/rev/f0f06d912b18