Closed Bug 1318210 Opened 3 years ago Closed 3 years ago

Remove nsIAppsService

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: nukeb2g
Attachment #8811559 - Flags: review?(amarchesini)
Comment on attachment 8811559 [details] [diff] [review]
Remove nsIAppsService

Review of attachment 8811559 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/network/NetworkStatsManager.js
@@ +181,5 @@
>                                    threshold: aThreshold,
>                                    startTime: aOptions.startTime,
>                                    data: aOptions.data,
> +                                  manifestURL: "",
> +                                  pageURL: ""}});

can we remove these entries from data?

@@ +195,5 @@
>      let request = this.createRequest();
>      cpmm.sendAsyncMessage("NetworkStats:GetAlarms",
>                            {id: this.getRequestId(request),
>                             data: {network: network,
> +                                  manifestURL: ""}});

ditto.

@@ +208,5 @@
>      let request = this.createRequest();
>      cpmm.sendAsyncMessage("NetworkStats:RemoveAlarms",
>                            {id: this.getRequestId(request),
>                             data: {alarmId: aAlarmId,
> +                                  manifestURL: ""}});

ditto.

::: dom/network/NetworkStatsService.jsm
@@ +408,5 @@
>      let callback = (function (aError, aResult) {
>        this._db.find(function onStatsFound(aError, aResult) {
>          mm.sendAsyncMessage("NetworkStats:Get:Return",
>                              { id: msg.id, error: aError, result: aResult });
> +      }, 0, browsingTrafficOnly, serviceType, network, start, end, null);

and maybe consider to remove this field in the db.
Attachment #8811559 - Flags: review?(amarchesini) → review+
In response to comment 2, all of this code (the network stats API) is pending removal, and it has never been used in Firefox, so I don't think our users will have any data we need to clear here.
https://hg.mozilla.org/mozilla-central/rev/1fdb5a1b0d86
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
No longer blocks: 1369194
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.