1318210 - Remove nsIAppsService

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Comment 1

[(no longer active)]

Attachment: Remove nsIAppsService

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8811559 [details] [diff] [review]
Remove nsIAppsService

Review of attachment 8811559 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/network/NetworkStatsManager.js
@@ +181,5 @@
>                                    threshold: aThreshold,
>                                    startTime: aOptions.startTime,
>                                    data: aOptions.data,
> +                                  manifestURL: "",
> +                                  pageURL: ""}});

can we remove these entries from data?

@@ +195,5 @@
>      let request = this.createRequest();
>      cpmm.sendAsyncMessage("NetworkStats:GetAlarms",
>                            {id: this.getRequestId(request),
>                             data: {network: network,
> +                                  manifestURL: ""}});

ditto.

@@ +208,5 @@
>      let request = this.createRequest();
>      cpmm.sendAsyncMessage("NetworkStats:RemoveAlarms",
>                            {id: this.getRequestId(request),
>                             data: {alarmId: aAlarmId,
> +                                  manifestURL: ""}});

ditto.

::: dom/network/NetworkStatsService.jsm
@@ +408,5 @@
>      let callback = (function (aError, aResult) {
>        this._db.find(function onStatsFound(aError, aResult) {
>          mm.sendAsyncMessage("NetworkStats:Get:Return",
>                              { id: msg.id, error: aError, result: aResult });
> +      }, 0, browsingTrafficOnly, serviceType, network, start, end, null);

and maybe consider to remove this field in the db.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1fdb5a1b0d86
Remove nsIAppsService; r=baku

Comment 4

[(no longer active)]

In response to comment 2, all of this code (the network stats API) is pending removal, and it has never been used in Firefox, so I don't think our users will have any data we need to clear here.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1fdb5a1b0d86

Comment 6

[areya]

https://hg.mozilla.org/mozilla-central/rev/1fdb5a1b0d86