1318335 - Convert some code in ipc/ to C++11

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators

Comment 1

[Andi [:andi]]

Attachment: Bug 1318335 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in ipc/.

Review commit: https://reviewboard.mozilla.org/r/93732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93732/

Comment 2

[Andi [:andi]]

Attachment: Bug 1318335 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in ipc/.

Review commit: https://reviewboard.mozilla.org/r/93734/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93734/

Comment 3

[Andi [:andi]]

Attachment: Bug 1318335 - Replace default bodies of special member functions with = default; in ipc/.

Review commit: https://reviewboard.mozilla.org/r/93736/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93736/

Comment 4

[Andi [:andi]]

Attachment: Bug 1318335 - Use C++11's override and remove virtual where applicable in ipc/.

Review commit: https://reviewboard.mozilla.org/r/93738/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/93738/

Comment 5

[Andi [:andi]]

Comment on attachment 8811732 [details]
Bug 1318335 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in ipc/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93732/diff/1-2/

Comment 6

[Andi [:andi]]

Comment on attachment 8811733 [details]
Bug 1318335 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in ipc/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93734/diff/1-2/

Comment 7

[Andi [:andi]]

Comment on attachment 8811734 [details]
Bug 1318335 - Replace default bodies of special member functions with = default; in ipc/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93736/diff/1-2/

Comment 8

[Andi [:andi]]

Comment on attachment 8811735 [details]
Bug 1318335 - Use C++11's override and remove virtual where applicable in ipc/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93738/diff/1-2/

Comment 9

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8811732 [details]
Bug 1318335 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in ipc/.

https://reviewboard.mozilla.org/r/93732/#review95018

::: ipc/glue/SharedMemoryBasic_mach.mm:454
(Diff revision 2)
>  void
>  SharedMemoryBasic::Shutdown()
>  {
>    StaticMutexAutoLock smal(gMutex);
>  
> -  for (auto it = gThreads.begin(); it != gThreads.end(); ++it) {
> +  for (auto& gThread : gThreads) {

Local variables shouldn't be named gFoo. Please just call this |thread|. Same for the others below.

Comment 10

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8811733 [details]
Bug 1318335 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in ipc/.

https://reviewboard.mozilla.org/r/93734/#review95020

Comment 11

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8811734 [details]
Bug 1318335 - Replace default bodies of special member functions with = default; in ipc/.

https://reviewboard.mozilla.org/r/93736/#review95022

::: ipc/glue/BackgroundParentImpl.cpp:402
(Diff revision 2)
>      }
>      return NS_OK;
>    }
>  
>  private:
> -  ~InitUDPSocketParentCallback() {};
> +  ~InitUDPSocketParentCallback() = default;;

Please remove the extra ;

Comment 12

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8811735 [details]
Bug 1318335 - Use C++11's override and remove virtual where applicable in ipc/.

https://reviewboard.mozilla.org/r/93738/#review95024

Comment 13

[Andi [:andi]]

Comment on attachment 8811732 [details]
Bug 1318335 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in ipc/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93732/diff/2-3/

Comment 14

[Andi [:andi]]

Comment on attachment 8811733 [details]
Bug 1318335 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in ipc/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93734/diff/2-3/

Comment 15

[Andi [:andi]]

Comment on attachment 8811734 [details]
Bug 1318335 - Replace default bodies of special member functions with = default; in ipc/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93736/diff/2-3/

Comment 16

[Andi [:andi]]

Comment on attachment 8811735 [details]
Bug 1318335 - Use C++11's override and remove virtual where applicable in ipc/.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/93738/diff/2-3/

Comment 17

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8811732 [details]
Bug 1318335 - Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in ipc/.

https://reviewboard.mozilla.org/r/93732/#review96188

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/841c964971a8
Converts for(...; ...; ...) loops to use the new range-based loops in C++11 in ipc/. r=billm
https://hg.mozilla.org/integration/autoland/rev/d27c040abf57
Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in ipc/. r=billm
https://hg.mozilla.org/integration/autoland/rev/e8582a4033dc
Replace default bodies of special member functions with = default; in ipc/. r=billm
https://hg.mozilla.org/integration/autoland/rev/6deceff197dc
Use C++11's override and remove virtual where applicable in ipc/. r=billm

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/841c964971a8
https://hg.mozilla.org/mozilla-central/rev/d27c040abf57
https://hg.mozilla.org/mozilla-central/rev/e8582a4033dc
https://hg.mozilla.org/mozilla-central/rev/6deceff197dc