1318411 - auth proxy should preserve query string

Status: RESOLVED FIXED

(Taskcluster :: Workers, defect)

Description

[(not currently active) Ted Mielczarek]

In bug 1316698 jonas added a ?format parameter to the awsS3Credentials method. Unfortunately the proxy does not preserve the query string, so this doesn't work in practice from a worker.

Comment 1

[(not currently active) Ted Mielczarek]

garndt: if you can get someone to fix this, I have a patch basically ready to go in bug 1269355.

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

Lol, I already started on this:
https://github.com/taskcluster/taskcluster-proxy/pull/25

While fixing it I decided to also fix it so that:
  http://taskcluster/auth.taskcluster.net/v1/...
Also works..

That way we don't have to hardcode urls...

Comment 3

[Greg Arndt [:garndt]]

Thanks jonas for jumping on that!

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/taskcluster/taskcluster-proxy

https://github.com/taskcluster/taskcluster-proxy/commit/b537b5d85f93f6063c42e78f9ae043a5ea144183
Bug 1318411 - Proxy should not strip querystring, also avoid hardcoding hostnames

https://github.com/taskcluster/taskcluster-proxy/commit/c8c7c98c2121a32dcfe9180d27f8215609e8daff
Merge pull request #25 from taskcluster/bug-1318411

Bug 1318411 - Proxy should not strip querystring, also avoid hardcodi…

Comment 5

[Jonas Finnemann Jensen (:jonasfj)]

Pushed to taskcluster/taskcluster-proxy:latest and taskcluster/taskcluster-proxy:3.1.0
See: https://hub.docker.com/r/taskcluster/taskcluster-proxy/tags/

I don't think we've hardcoded the version used in docker-worker, so this will likely just get adopted
over the next 72 hours.
If we get errors we'll roll back.

Until this consider this fixed, it'll take effect over the course of the next 72 hours.

Comment 6

[Jonas Finnemann Jensen (:jonasfj)]

Note: If we need to rollback, the previous release was either:
 - 3.0.10 or
 - 3.0.9
Changing the label of :latest should roll it back.