131852 - [FIX]Mozilla should use "global" print settings

Status: VERIFIED FIXED

(Core :: Printing: Output, defect)

Description

[rods (gone)]

Comment 1

[Kevin McCluskey (gone)]

nsbeta1+

Comment 2

[rods (gone)]

Attachment: patch

Besides turning on the pref, I needed to move the initialization code for
getting the values from the default printer from the DocumentViewer down into
the PrintOptions service. 

We want it done only the very first time when the PrintSettings is created.

Comment 3

[rods (gone)]

Instead of putting up a new patch, I thought I would mention I changed the
following in nsPrintOptionsImpl:
      if (prtEnum) {
to:
      if (NS_SUCCEEDED(rv)) {

Comment 4

[Marc Attinasi]

Comment on attachment 74845 [details] [diff] [review]
patch

sr=attinasi, but I personally prefer the check for null on prtEnum vs. the
check for rv, though they are probably synonymous (some slackers code it so
that rv is NS_OK even though the object is null).

Comment 5

[rods (gone)]

This case it is a return code from do_Service so the rv should always set correctly.

Comment 6

[dcone (gone)]

Comment on attachment 74845 [details] [diff] [review]
patch

r=dcone

Comment 7

[Samir Gehani]

*** Bug 127258 has been marked as a duplicate of this bug. ***

Comment 8

[Scott Collins]

Comment on attachment 74845 [details] [diff] [review]
patch

a=scc

Comment 9

[rods (gone)]

fixed

Comment 10

[sujay]

Rod, please verify...thanks!

Comment 11

[sujay]

verified.