1318576 - Past names map is not updated when an element that no longer has a name/id is removed from the form

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[myvyang]

Attachment: attr.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.98 Safari/537.36

Steps to reproduce:

as code attached in attr.html

in other browsers, after removeChild, attributes will be update; but on firefox not.


Actual results:

in firefox, console shows `<input>`

in other browser ,like chrome, safari ,IE, console shows `NamedNodeMap`


Expected results:

run like other browser

Comment 1

[Loic]

Boris, can you check if Gecko behaves normaly according to the specs and the other browsers, please.

Comment 2

[Boris Zbarsky [:bzbarsky]]

The relevant spec bit here is:

  If an element listed in a form element's past names map changes form owner, then its entries must be
  removed from that map.

We definitely have code to do that in HTMLFormElement::RemoveElementFromTable.  The problem is that this code is only called when the element has a name/id that should place it in the table.  I'll write up a fix.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Remove entries from a form's past names map when an element is removed from the form, even if that element doesn't have a name or id anymore

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8812408 [details] [diff] [review]
Remove entries from a form's past names map when an element is removed from the form, even if that element doesn't have a name or id anymore

Review of attachment 8812408 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/HTMLFormElement.cpp
@@ +2560,5 @@
> +  if (!aElement->HasFlag(MAY_BE_IN_PAST_NAMES_MAP)) {
> +    return;
> +  }
> +
> +  aElement->UnsetFlags(MAY_BE_IN_PAST_NAMES_MAP);  

extra spaces.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a9eb529688b
Remove entries from a form's past names map when an element is removed from the form, even if that element doesn't have a name or id anymore.  r=baku

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2a9eb529688b