Closed Bug 1318618 Opened 3 years ago Closed 3 years ago

Support nsCString data type in gfxPrefs in OOP compositor

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

References

Details

Attachments

(1 file)

Currently, our GfxPrefValue in PGPU.ipdl doesn't support nsCString data type that would affect some preferences can't be accessed in the compositor process.
Assignee: nobody → dmu
Ideally, we should choose nsCString as the data type for gfxPrefs to add values to Preference. However, there are some other files will include gfxPrefs.h outside XUL, and "nsStringFwd.h" can't be included by this kind of files. Otherwise, it would have an error like "#error Internal string headers are not available from external-linkage code."

Therefore, I select to use std::string for implementing this.
Comment on attachment 8813478 [details]
Bug 1318618 - Support nsCString data type in gfxPrefs;

https://reviewboard.mozilla.org/r/94892/#review95386
Attachment #8813478 - Flags: review?(dvander) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a8dabadba0ab
Support nsCString data type in gfxPrefs; r=dvander
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a8dabadba0ab
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.