1318618 - Support nsCString data type in gfxPrefs in OOP compositor

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Daosheng Mu[:daoshengmu]]

Currently, our GfxPrefValue in PGPU.ipdl doesn't support nsCString data type that would affect some preferences can't be accessed in the compositor process.

Comment 1

[Daosheng Mu[:daoshengmu]]

Attachment: Bug 1318618 - Support nsCString data type in gfxPrefs;

Review commit: https://reviewboard.mozilla.org/r/94892/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94892/

Comment 2

[Daosheng Mu[:daoshengmu]]

Ideally, we should choose nsCString as the data type for gfxPrefs to add values to Preference. However, there are some other files will include gfxPrefs.h outside XUL, and "nsStringFwd.h" can't be included by this kind of files. Otherwise, it would have an error like "#error Internal string headers are not available from external-linkage code."

Therefore, I select to use std::string for implementing this.

Comment 3

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8813478 [details]
Bug 1318618 - Support nsCString data type in gfxPrefs;

https://reviewboard.mozilla.org/r/94892/#review95386

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8dabadba0ab
Support nsCString data type in gfxPrefs; r=dvander

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a8dabadba0ab