1318619 - Update cubeb from upstream to 7f74039f92

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Alex Chronopoulos [:achronop]]

Update cubeb from upstream to 7f74039f92

Comment 1

[Alex Chronopoulos [:achronop]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2be605ce027c1dfbf6c770a018f966854147149c
Bug 1318619 - Update cubeb upstream to 7f74039f92. r=kinetik

Comment 2

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2be605ce027c

Comment 3

[Masatoshi Kimura [:emk]]

This change broke the WinXP support on Nightly. Do we need to backout this patch until the updater block updating on WinXP? Or do we declare we actually dropped support for WinXP now?

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

(In reply to Masatoshi Kimura [:emk] from comment #3)
> This change broke the WinXP support on Nightly. Do we need to backout this
> patch until the updater block updating on WinXP? Or do we declare we
> actually dropped support for WinXP now?

Can you detail what's broken on XP?  Most of us don't have access to an XP machine...

Comment 5

[Masatoshi Kimura [:emk]]

The previous cubeb was using LoadLibrary/GetProcAddress to load AVRT.dll dynamically because AVRT.dll is only available Win7 or later.

Apparently the newest cubeb no longer supports WinXP, so cubeb implicitly links to AVRT.dll instead of using LoadLibrary/GetProcAddress. So xul.dll will fail to load on WinXP.

Search for AvRevertMmThreadCharacteristics and AvSetMmThreadCharacteristics in the changeset.

Comment 6

[Masatoshi Kimura [:emk]]

The user-visible effect: The latest Nightly will not even start on WinXP. It will only display "Couldn't load XPCOM." error.

Comment 7

[areya]

https://hg.mozilla.org/mozilla-central/rev/2be605ce027c

Comment 8

[Matthew Gregan [:kinetik]]

My mistake.

We need to revert https://github.com/kinetiknz/cubeb/commit/c0ec4416790019565c344c29f1b2eff91531145a from upstream.

I'll sort it out tomorrow AM.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c788e6d12d93
Update libcubeb to 13f167c2.

Comment 10

[Matthew Gregan [:kinetik]]

(In reply to Matthew Gregan [:kinetik] from comment #8)
> My mistake.
> 
> We need to revert
> https://github.com/kinetiknz/cubeb/commit/
> c0ec4416790019565c344c29f1b2eff91531145a from upstream.
> 
> I'll sort it out tomorrow AM.

Landed in comment 9.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c788e6d12d93