1318627 - Remove Zone::active

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

This flag is set when we GC while the zone has frames on the stack, to inhibit releasing types in beginSweepTypes, but this is no longer necessary for correctness and it lets us remove some code.

Comment 1

[Jon Coppeard (:jonco)]

Comment on attachment 8812131 [details] [diff] [review]
Patch

Review of attachment 8812131 [details] [diff] [review]:
-----------------------------------------------------------------

I'm happy to remove the flag if this is safe.

Comment 2

[Jan de Mooij [:jandem]]

bhackett, feedback ping?

Comment 3

[Brian Hackett [Laid off!]]

(In reply to Jan de Mooij [:jandem] from comment #2)
> bhackett, feedback ping?

Sorry, I didn't notice this request.  This patch looks fine.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/853a0dfc4d5f
Remove Zone::active and related infrastructure. r=jonco, f=bhackett

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/698bbf4f2e26
followup - Add br_table.wast.js to cgc-jittest-timeouts.txt. r=bustage

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/853a0dfc4d5f
https://hg.mozilla.org/mozilla-central/rev/698bbf4f2e26