Closed Bug 1318640 Opened 7 years ago Closed 7 years ago

Closing the captive portal tab should go back to the previously selected tab

Categories

(Firefox :: General, defect)

Product:
Firefox
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 53
Iteration:
53.1 - Nov 28
Tracking Flags:
Tracking Status
firefox52 --- wontfix
firefox53 --- verified

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file)

patch
1.12 KB, patch
nhnt11
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
addTab's ownerTab parameter makes it so that closing the captive portal tab automatically selects the previously selected tab rather than the one that's adjacent to the captive portal tab.
Attachment #8812146 - Flags: review?(nhnt11)
Comment on attachment 8812146 [details] [diff] [review]
patch

Review of attachment 8812146 [details] [diff] [review]:
-----------------------------------------------------------------

Nice improvement, thanks!
Attachment #8812146 - Flags: review?(nhnt11) → review+
Comment on attachment 8812146 [details] [diff] [review]
patch

Review of attachment 8812146 [details] [diff] [review]:
-----------------------------------------------------------------

This could use tests - both for the automatically-opened case and the opened-from-notification-bar case. Dao, do you have time to write them? If not, I'd be happy to take over.
(In reply to Nihanth Subramanya [:nhnt11] from comment #2)
> Comment on attachment 8812146 [details] [diff] [review]
> patch
> 
> Review of attachment 8812146 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This could use tests - both for the automatically-opened case and the
> opened-from-notification-bar case. Dao, do you have time to write them?

Nope.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1b1f80184ca
Closing the captive portal tab should go back to the previously selected tab. r=nhnt11
https://hg.mozilla.org/mozilla-central/rev/d1b1f80184ca
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Iteration: --- → 53.1 - Nov 28
Verified on 53.0a1 20170119030211 as fixed.
Updating tracking flags as this change wasn't uplifted so it's still affecting 52.0a2 20170119004006.
status-firefox52: --- → affected
status-firefox53: fixed → verified
You need to log in before you can comment on or make changes to this bug.