Closed
Bug 1318640
Opened 8 years ago
Closed 8 years ago
Closing the captive portal tab should go back to the previously selected tab
Categories
(Firefox :: General, defect)
Firefox
General
Tracking
()
People
(Reporter: dao, Assigned: dao)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxprivacy])
Attachments
(1 file)
1.12 KB,
patch
|
nhnt11
:
review+
|
Details | Diff | Splinter Review |
addTab's ownerTab parameter makes it so that closing the captive portal tab automatically selects the previously selected tab rather than the one that's adjacent to the captive portal tab.
Attachment #8812146 -
Flags: review?(nhnt11)
Comment 1•8 years ago
|
||
Comment on attachment 8812146 [details] [diff] [review]
patch
Review of attachment 8812146 [details] [diff] [review]:
-----------------------------------------------------------------
Nice improvement, thanks!
Attachment #8812146 -
Flags: review?(nhnt11) → review+
Comment 2•8 years ago
|
||
Comment on attachment 8812146 [details] [diff] [review]
patch
Review of attachment 8812146 [details] [diff] [review]:
-----------------------------------------------------------------
This could use tests - both for the automatically-opened case and the opened-from-notification-bar case. Dao, do you have time to write them? If not, I'd be happy to take over.
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Nihanth Subramanya [:nhnt11] from comment #2)
> Comment on attachment 8812146 [details] [diff] [review]
> patch
>
> Review of attachment 8812146 [details] [diff] [review]:
> -----------------------------------------------------------------
>
> This could use tests - both for the automatically-opened case and the
> opened-from-notification-bar case. Dao, do you have time to write them?
Nope.
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1b1f80184ca
Closing the captive portal tab should go back to the previously selected tab. r=nhnt11
Comment 5•8 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Updated•8 years ago
|
Iteration: --- → 53.1 - Nov 28
Comment 6•8 years ago
|
||
Verified on 53.0a1 20170119030211 as fixed.
Updating tracking flags as this change wasn't uplifted so it's still affecting 52.0a2 20170119004006.
status-firefox52:
--- → affected
Comment 7•8 years ago
|
||
Too late for 52.
You need to log in
before you can comment on or make changes to this bug.
Description
•