1318796 - Web Console CSS links should open the Style Editor

Status: VERIFIED FIXED

(DevTools :: Console, defect, P2)

Description

[johngraciliano]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20161118030222

Steps to reproduce:

(I am glad about the inclusion of CSS in the new Web Console. However...)
Open Firefox 53.
Visit "https://duckduckgo.com/"
Open the Web Console.
Ensure showing Warnings and CSS (through the Filter symbol.)
Click on a css file link in one of the messages (t1222.css).


Actual results:

The css file is opened in the browser. (Close it this tab.)
The Debugger is open within the tools for the original page.


Expected results:

The file should open in the Style Editor and the Debugger should remain inactive.


This is a regression to Bug ID #782653

Comment 1

[Brian Grinstead [:bgrins]]

Thanks for filing.  We are attempting to open the debugger in this case but should be going to the style editor as you say

Comment 2

[Tim Nguyen :ntim]

This should be an option to pass into the frame component.

Also, it might be nice to support Scratchpad links:
https://dxr.mozilla.org/mozilla-central/source/devtools/client/webconsole/webconsole.js#2584

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

> Also, it might be nice to support Scratchpad links:

You read my mind, I have an almost-ready patch which does that : open the adequate tool (debugger, style editor, scratchpad) when clicking on location, even in the stacktrace

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1318796 - Open the appropriate tool when clicking on a location in the new console;

We were always opening the debugger when clicking on the location link,
which could be wrong since we can have CSS warnings, or logs coming from Scratchpad.
So we add the function to open in StyleEditor and Scratchpad, and copy some mochitests
that where testing the interaction with those links.

Review commit: https://reviewboard.mozilla.org/r/97898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97898/

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8819954 [details]
Bug 1318796 - Open the appropriate tool when clicking on a location in the new console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97898/diff/1-2/

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

TRY looks fine https://treeherder.mozilla.org/#/jobs?repo=try&revision=95838d0b7397

Comment 7

[Julian Descottes [:jdescottes]]

Comment on attachment 8819954 [details]
Bug 1318796 - Open the appropriate tool when clicking on a location in the new console;

https://reviewboard.mozilla.org/r/97898/#review100120

Great patch Nicolas, thanks!

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_stacktrace_location_scratchpad_link.js:11
(Diff revision 2)
> +"use strict";
> +
> +const TEST_URI = "data:text/html;charset=utf8,<p>test stacktrace scratchpad linking</p>";
> +
> +add_task(function* () {
> +  Services.prefs.setBoolPref("devtools.scratchpad.enabled", true);

Register a cleanup function to clear the pref or use pushPref from shared-head.js

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_stacktrace_location_scratchpad_link.js:52
(Diff revision 2)
> +  info("Clicking link to switch to and focus Scratchpad");
> +
> +  ok(message, "Found console.trace message from Scratchpad");
> +  let anchor = message.querySelector(".stack-trace .frame-link .frame-link-filename");
> +
> +  let onScratchpadSelected = new Promise((resolve) => {

can be simplified as let onScratchpadSelected = toolbox.once("scratchpad-selected");

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_location_styleeditor_link.js:11
(Diff revision 2)
> -                 "/test-bug-782653-css-errors.html";
> -
> -var nodes, hud, StyleEditorUI;
>  
>  add_task(function* () {
> -  yield loadTab(TEST_URI);
> +  Services.prefs.setBoolPref("devtools.webconsole.filter.css", true);

Register a cleanup function to clear the pref or use pushPref from shared-head.js

::: devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_location_scratchpad_link.js:11
(Diff revision 2)
> -  SpecialPowers.pushPrefEnv(options, deferred.resolve);
> -  return deferred.promise;
> -}
>  
>  add_task(function* () {
> -  waitForExplicitFinish();
> +  Services.prefs.setBoolPref("devtools.scratchpad.enabled", true);

Register a cleanup function to clear the pref or use pushPref from shared-head.js

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8819954 [details]
Bug 1318796 - Open the appropriate tool when clicking on a location in the new console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97898/diff/2-3/

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8819954 [details]
Bug 1318796 - Open the appropriate tool when clicking on a location in the new console;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/97898/diff/3-4/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7cfa5f7c0ec2
Open the appropriate tool when clicking on a location in the new console; r=jdescottes

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7cfa5f7c0ec2

Comment 12

[Tanvir Rahman]

I have reproduced this bug with Nightly 53.0a1 (2016-11-18) (32-bit) on WIndows 10 , 64 Bit.
This bug's fix is now verified on latest Nightly 53.0a1.

Build ID :	20161230030205
User Agent : Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0

[bugday-20161228]