Closed
Bug 1318833
Opened 6 years ago
Closed 6 years ago
Remove Silverlight plugin quirk compatibility
Categories
(Core Graveyard :: Plug-ins, defect)
Core Graveyard
Plug-ins
Tracking
(firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox53 fixed)
People
(Reporter: cpeterson, Assigned: cpeterson)
References
Details
Attachments
(4 files)
|
11.21 KB,
patch
|
qdot
:
review+
|
Details | Diff | Splinter Review |
|
14.59 KB,
patch
|
jimm
:
review+
|
Details | Diff | Splinter Review |
|
8.77 KB,
patch
|
gerald
:
review+
|
Details | Diff | Splinter Review |
|
2.57 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
Part 1: Remove Silverlight plugin tests and test plugin. These patches remove special-case code for the Silverlight plugin. We no longer support plugins other than Flash as of Firefox 53.
Attachment #8812409 -
Flags: review?(kyle)
|
Assignee | |
Comment 1•6 years ago
|
||
Part 2: Remove Silverlight plugin quirk compatibility like eSpecialType_Silverlight, QUIRK_SILVERLIGHT_DEFAULT_TRANSPARENT, and QUIRK_SILVERLIGHT_FOCUS_CHECK_PARENT.
Attachment #8812410 -
Flags: review?(jmathies)
|
|
Assignee | |
Comment 2•6 years ago
|
||
Part 3: Remove unused Silverlight checks from Decoder Doctor.
Attachment #8812412 -
Flags: review?(gsquelart)
|
|
Assignee | |
Comment 3•6 years ago
|
||
Part 4: Remove -allow_heap_execute linker flag, added for OS X 10.7 compat in bug 753248, that is no longer needed for Silverlight.
Attachment #8812413 -
Flags: review?(ted)
|
|
Assignee | |
Comment 4•6 years ago
|
||
Comment on attachment 8812412 [details] [diff] [review] part-3-remove-Silverlight-from-DecoderDoctor.patch Here is a mostly green Try run with all these patches: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f87625e5c5b7b524250f6f55ee7996b86b7803a
Attachment #8812412 -
Attachment filename: 1318833_remove-Silverlight-from-DecoderDoctor.patch → part-3-remove-Silverlight-from-DecoderDoctor.patch
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8812412 -
Attachment description: remove-Silverlight-from-DecoderDoctor.patch → part-3-remove-Silverlight-from-DecoderDoctor.patch
|
||
Updated•6 years ago
|
Attachment #8812412 -
Flags: review?(gsquelart) → review+
|
||
Updated•6 years ago
|
Attachment #8812413 -
Flags: review?(ted) → review+
|
||
Updated•6 years ago
|
Attachment #8812409 -
Flags: review?(kyle) → review+
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fc3a99e3d24a Part 1: Remove Silverlight plugin tests and test plugin. r=qdot https://hg.mozilla.org/integration/mozilla-inbound/rev/138abd270223 Part 3: Remove unused Silverlight checks from Decoder Doctor. r=gerald
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4bf6b81fa61a Part 4: Remove -allow_heap_execute linker flag that is no longer needed for Silverlight. r=ted
|
|
Assignee | |
Updated•6 years ago
|
Keywords: leave-open
|
||
Comment 7•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc3a99e3d24a https://hg.mozilla.org/mozilla-central/rev/138abd270223 https://hg.mozilla.org/mozilla-central/rev/4bf6b81fa61a
|
||
Comment 8•6 years ago
|
||
Comment on attachment 8812410 [details] [diff] [review] part-2-remove-Silverlight-quirks.patch Review of attachment 8812410 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/plugins/ipc/PluginInstanceChild.cpp @@ -2482,5 @@ > // our ui thread. So we hook TrackPopupMenu so we can hand in a surrogate > // parent created in the child process. > if ((GetQuirks() & QUIRK_WINLESS_TRACKPOPUP_HOOK) && // XXX turn on by default? > - (event.event == WM_RBUTTONDOWN || // flash > - event.event == WM_RBUTTONUP)) { // silverlight lets not take these event handlers out. they are harmless.
Attachment #8812410 -
Flags: review?(jmathies) → review+
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/f1362a9e0f4e Part 2: Remove Silverlight plugin quirk compatibility. r=jimm
|
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f1362a9e0f4e
|
|
||
Comment 11•6 years ago
|
||
Is there anything left to be done here?
|
|
Assignee | |
Comment 12•6 years ago
|
||
(In reply to Guilherme Lima from comment #11) > Is there anything left to be done here? Nope. The last patch landed yesterday. Thanks for the reminder!
|
||
Updated•3 months ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•