1318833 - Remove Silverlight plugin quirk compatibility

Status: RESOLVED FIXED

(Core :: Plug-ins, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: part-1-remove-Silverlight-tests.patch

Part 1: Remove Silverlight plugin tests and test plugin.

These patches remove special-case code for the Silverlight plugin. We no longer support plugins other than Flash as of Firefox 53.

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: part-2-remove-Silverlight-quirks.patch

Part 2: Remove Silverlight plugin quirk compatibility like eSpecialType_Silverlight, QUIRK_SILVERLIGHT_DEFAULT_TRANSPARENT, and QUIRK_SILVERLIGHT_FOCUS_CHECK_PARENT.

Comment 2

[Chris Peterson [:cpeterson]]

Attachment: part-3-remove-Silverlight-from-DecoderDoctor.patch

Part 3: Remove unused Silverlight checks from Decoder Doctor.

Comment 3

[Chris Peterson [:cpeterson]]

Attachment: part-4-remove-allow_heap_execute-flag.patch

Part 4: Remove -allow_heap_execute linker flag, added for OS X 10.7 compat in bug 753248, that is no longer needed for Silverlight.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 8812412 [details] [diff] [review]
part-3-remove-Silverlight-from-DecoderDoctor.patch

Here is a mostly green Try run with all these patches:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f87625e5c5b7b524250f6f55ee7996b86b7803a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc3a99e3d24a
Part 1: Remove Silverlight plugin tests and test plugin. r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/138abd270223
Part 3: Remove unused Silverlight checks from Decoder Doctor. r=gerald

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bf6b81fa61a
Part 4: Remove -allow_heap_execute linker flag that is no longer needed for Silverlight. r=ted

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fc3a99e3d24a
https://hg.mozilla.org/mozilla-central/rev/138abd270223
https://hg.mozilla.org/mozilla-central/rev/4bf6b81fa61a

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 8812410 [details] [diff] [review]
part-2-remove-Silverlight-quirks.patch

Review of attachment 8812410 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginInstanceChild.cpp
@@ -2482,5 @@
>      // our ui thread. So we hook TrackPopupMenu so we can hand in a surrogate
>      // parent created in the child process.
>      if ((GetQuirks() & QUIRK_WINLESS_TRACKPOPUP_HOOK) && // XXX turn on by default?
> -          (event.event == WM_RBUTTONDOWN || // flash
> -           event.event == WM_RBUTTONUP)) {  // silverlight

lets not take these event handlers out. they are harmless.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1362a9e0f4e
Part 2: Remove Silverlight plugin quirk compatibility. r=jimm

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f1362a9e0f4e

Comment 11

[Guilherme Lima]

Is there anything left to be done here?

Comment 12

[Chris Peterson [:cpeterson]]

(In reply to Guilherme Lima from comment #11)
> Is there anything left to be done here?

Nope. The last patch landed yesterday. Thanks for the reminder!