Remove Silverlight plugin quirk compatibility

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox53 fixed)

Details

Attachments

(4 attachments)

Part 1: Remove Silverlight plugin tests and test plugin.

These patches remove special-case code for the Silverlight plugin. We no longer support plugins other than Flash as of Firefox 53.
Attachment #8812409 - Flags: review?(kyle)
Part 2: Remove Silverlight plugin quirk compatibility like eSpecialType_Silverlight, QUIRK_SILVERLIGHT_DEFAULT_TRANSPARENT, and QUIRK_SILVERLIGHT_FOCUS_CHECK_PARENT.
Attachment #8812410 - Flags: review?(jmathies)
Part 3: Remove unused Silverlight checks from Decoder Doctor.
Attachment #8812412 - Flags: review?(gsquelart)
Part 4: Remove -allow_heap_execute linker flag, added for OS X 10.7 compat in bug 753248, that is no longer needed for Silverlight.
Attachment #8812413 - Flags: review?(ted)
Comment on attachment 8812412 [details] [diff] [review]
part-3-remove-Silverlight-from-DecoderDoctor.patch

Here is a mostly green Try run with all these patches:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f87625e5c5b7b524250f6f55ee7996b86b7803a
Attachment #8812412 - Attachment filename: 1318833_remove-Silverlight-from-DecoderDoctor.patch → part-3-remove-Silverlight-from-DecoderDoctor.patch
Attachment #8812412 - Attachment description: remove-Silverlight-from-DecoderDoctor.patch → part-3-remove-Silverlight-from-DecoderDoctor.patch
Attachment #8812412 - Flags: review?(gsquelart) → review+
Attachment #8812413 - Flags: review?(ted) → review+
Attachment #8812409 - Flags: review?(kyle) → review+
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc3a99e3d24a
Part 1: Remove Silverlight plugin tests and test plugin. r=qdot
https://hg.mozilla.org/integration/mozilla-inbound/rev/138abd270223
Part 3: Remove unused Silverlight checks from Decoder Doctor. r=gerald
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bf6b81fa61a
Part 4: Remove -allow_heap_execute linker flag that is no longer needed for Silverlight. r=ted
Keywords: leave-open
Comment on attachment 8812410 [details] [diff] [review]
part-2-remove-Silverlight-quirks.patch

Review of attachment 8812410 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/plugins/ipc/PluginInstanceChild.cpp
@@ -2482,5 @@
>      // our ui thread. So we hook TrackPopupMenu so we can hand in a surrogate
>      // parent created in the child process.
>      if ((GetQuirks() & QUIRK_WINLESS_TRACKPOPUP_HOOK) && // XXX turn on by default?
> -          (event.event == WM_RBUTTONDOWN || // flash
> -           event.event == WM_RBUTTONUP)) {  // silverlight

lets not take these event handlers out. they are harmless.
Attachment #8812410 - Flags: review?(jmathies) → review+
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f1362a9e0f4e
Part 2: Remove Silverlight plugin quirk compatibility. r=jimm
Is there anything left to be done here?
(In reply to Guilherme Lima from comment #11)
> Is there anything left to be done here?

Nope. The last patch landed yesterday. Thanks for the reminder!
Status: NEW → RESOLVED
Closed: 3 years ago
Keywords: leave-open
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.