Closed Bug 1318879 Opened 3 years ago Closed 3 years ago

Remove the app related code from mozprofile

Categories

(Testing :: General, defect)

defect
Not set

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: Ehsan, Assigned: Ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → ehsan
Blocks: nukeb2g
Attachment #8812469 - Flags: review?(ahalberstadt)
Comment on attachment 8812469 [details] [diff] [review]
Remove the app related code from mozprofile

Review of attachment 8812469 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, lgtm!
Attachment #8812469 - Flags: review?(ahalberstadt) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de975fd9cbf6
Remove the app related code from mozprofile; r=ahal
Backed out for mass mochitest failures:

https://hg.mozilla.org/integration/mozilla-inbound/rev/acf3c2497b43ad6537bfbbd91d23eaaa5302afca

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=de975fd9cbf654f2b1c17db01a7544995da65611
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=39555236&repo=mozilla-inbound

[task 2016-11-21T16:07:02.830046Z] 16:07:02     INFO - TEST-START | testing/mochitest/tests/browser/browser_zz_fail_openwindow.js
[task 2016-11-21T16:07:02.831709Z] 16:07:02     INFO - TEST-SKIP | testing/mochitest/tests/browser/browser_zz_fail_openwindow.js | took 0ms
[task 2016-11-21T16:07:02.833286Z] 16:07:02     INFO -  dir: browser/base/content/test/plugins
[task 2016-11-21T16:07:07.122595Z] 16:07:07     INFO -  ImportError: No module named pygtk
[task 2016-11-21T16:07:07.342762Z] 16:07:07     INFO -  Setting pipeline to PAUSED ...
[task 2016-11-21T16:07:07.346444Z] 16:07:07     INFO -  Pipeline is PREROLLING ...
[task 2016-11-21T16:07:07.350348Z] 16:07:07     INFO -  Pipeline is PREROLLED ...
[task 2016-11-21T16:07:07.350541Z] 16:07:07     INFO -  Setting pipeline to PLAYING ...
[task 2016-11-21T16:07:07.352357Z] 16:07:07     INFO -  New clock: GstSystemClock
[task 2016-11-21T16:07:07.384160Z] 16:07:07     INFO -  Got EOS from element "pipeline0".
[task 2016-11-21T16:07:07.384371Z] 16:07:07     INFO -  Execution ended after 32267732 ns.
[task 2016-11-21T16:07:07.384543Z] 16:07:07     INFO -  Setting pipeline to PAUSED ...
[task 2016-11-21T16:07:07.386096Z] 16:07:07     INFO -  Setting pipeline to READY ...
[task 2016-11-21T16:07:07.392291Z] 16:07:07     INFO -  Setting pipeline to NULL ...
[task 2016-11-21T16:07:07.393750Z] 16:07:07     INFO -  Freeing pipeline ...
[task 2016-11-21T16:07:07.468057Z] 16:07:07     INFO -  21
[task 2016-11-21T16:07:07.536287Z] 16:07:07     INFO -  Exception AttributeError: "'Profile' object has no attribute 'restore'" in <bound method Profile.__del__ of <mozprofile.profile.Profile object at 0x272fd90>> ignored
[task 2016-11-21T16:07:07.536560Z] 16:07:07     INFO -  Traceback (most recent call last):
[task 2016-11-21T16:07:07.536847Z] 16:07:07     INFO -    File "/home/worker/workspace/build/tests/mochitest/runtests.py", line 2708, in <module>
[task 2016-11-21T16:07:07.537009Z] 16:07:07     INFO -      sys.exit(cli())
[task 2016-11-21T16:07:07.537263Z] 16:07:07     INFO -    File "/home/worker/workspace/build/tests/mochitest/runtests.py", line 2705, in cli
[task 2016-11-21T16:07:07.537453Z] 16:07:07     INFO -      return run_test_harness(parser, options)
[task 2016-11-21T16:07:07.539528Z] 16:07:07     INFO -    File "/home/worker/workspace/build/tests/mochitest/runtests.py", line 2674, in run_test_harness
[task 2016-11-21T16:07:07.540951Z] 16:07:07     INFO -      result = runner.runTests(options)
[task 2016-11-21T16:07:07.542459Z] 16:07:07     INFO -    File "/home/worker/workspace/build/tests/mochitest/runtests.py", line 2221, in runTests
[task 2016-11-21T16:07:07.544160Z] 16:07:07     INFO -      result = self.runMochitests(options, tests_in_dir)
[task 2016-11-21T16:07:07.546005Z] 16:07:07     INFO -    File "/home/worker/workspace/build/tests/mochitest/runtests.py", line 2161, in runMochitests
[task 2016-11-21T16:07:07.552158Z] 16:07:07     INFO -      result = self.doTests(options, testsToRun)
[task 2016-11-21T16:07:07.554599Z] 16:07:07     INFO -    File "/home/worker/workspace/build/tests/mochitest/runtests.py", line 2303, in doTests
[task 2016-11-21T16:07:07.556193Z] 16:07:07     INFO -      self.manifest = self.buildProfile(options)
[task 2016-11-21T16:07:07.557867Z] 16:07:07     INFO -    File "/home/worker/workspace/build/tests/mochitest/runtests.py", line 1716, in buildProfile
[task 2016-11-21T16:07:07.559296Z] 16:07:07     INFO -      proxy=proxy
[task 2016-11-21T16:07:07.560883Z] 16:07:07     INFO -  TypeError: __init__() got an unexpected keyword argument 'apps'
Flags: needinfo?(ehsan)
Ah, didn't realize this was being passed in through a non-b2g code path. It's probably safe to just remove the 'apps=apps' line.. might need to do it for reftest/xpcshell/marionette harnesses as well.
Looks like we can remove webapps_mochitest.json as well!
Flags: needinfo?(ehsan)
Attachment #8812813 - Flags: review?(ahalberstadt)
Comment on attachment 8812813 [details] [diff] [review]
Remove the app related code from mozprofile

Review of attachment 8812813 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8812813 - Flags: review?(ahalberstadt) → review+
Attachment #8812469 - Attachment is obsolete: true
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0cafbf944d89
Remove the app related code from mozprofile; r=ahal
Sorry, I'll run a full builds+tests try run.  :(
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c80366f680d8
Remove the app related code from mozprofile; r=ahal
https://hg.mozilla.org/mozilla-central/rev/c80366f680d8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.