Closed
Bug 1318883
Opened 8 years ago
Closed 8 years ago
Remove the NetworkStats API and related code
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
218.29 KB,
patch
|
baku
:
review+
mcmanus
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8812476 -
Flags: review?(mcmanus)
Attachment #8812476 -
Flags: review?(amarchesini)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8812476 [details] [diff] [review] Remove the NetworkStats API and related code Review of attachment 8812476 [details] [diff] [review]: ----------------------------------------------------------------- oh... I really like this API. Wondering if it makes sense to keep it for some other purpose, addons? webExtensions? a network about page? But, a part of this, the patch seems fine to me.
Attachment #8812476 -
Flags: review?(amarchesini) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
At least part of the implementation needs to change if we want to keep this around since this mostly accounts for per-app usage. I'm not aware of any concrete use cases, but at any rate the code is in the history if someone needs to dig it up again.
|
||
Comment 4•8 years ago
|
||
Comment on attachment 8812476 [details] [diff] [review] Remove the NetworkStats API and related code Review of attachment 8812476 [details] [diff] [review]: ----------------------------------------------------------------- I kind of like this code too but appreciate that it isn't right anymore. If you want to toss a comment into somewhere like nsHttpTransaction::WriteRequestSegment() with this bug # in case someone needs to recreate the byte counters that might be helpful.
Attachment #8812476 -
Flags: review?(mcmanus) → review+
|
|
Assignee | |
Comment 5•8 years ago
|
||
Sure, will do!
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ef303d80d12 Remove the NetworkStats API and related code; r=baku,mcmanus
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9ef303d80d12
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•