Closed Bug 1318883 Opened 3 years ago Closed 3 years ago

Remove the NetworkStats API and related code

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → ehsan
Blocks: nukeb2g
Attachment #8812476 - Flags: review?(mcmanus)
Attachment #8812476 - Flags: review?(amarchesini)
Comment on attachment 8812476 [details] [diff] [review]
Remove the NetworkStats API and related code

Review of attachment 8812476 [details] [diff] [review]:
-----------------------------------------------------------------

oh... I really like this API. Wondering if it makes sense to keep it for some other purpose, addons? webExtensions? a network about page?
But, a part of this, the patch seems fine to me.
Attachment #8812476 - Flags: review?(amarchesini) → review+
At least part of the implementation needs to change if we want to keep this around since this mostly accounts for per-app usage.  I'm not aware of any concrete use cases, but at any rate the code is in the history if someone needs to dig it up again.
Comment on attachment 8812476 [details] [diff] [review]
Remove the NetworkStats API and related code

Review of attachment 8812476 [details] [diff] [review]:
-----------------------------------------------------------------

I kind of like this code too but appreciate that it isn't right anymore. If you want to toss a comment into somewhere like nsHttpTransaction::WriteRequestSegment() with this bug # in case someone needs to recreate the byte counters that might be helpful.
Attachment #8812476 - Flags: review?(mcmanus) → review+
Sure, will do!
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ef303d80d12
Remove the NetworkStats API and related code; r=baku,mcmanus
https://hg.mozilla.org/mozilla-central/rev/9ef303d80d12
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
No longer blocks: 1369194
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.