Remove MOZ_INCOMPLETE_EXTERNAL_LINKAGE from c-c

RESOLVED FIXED in Thunderbird 53.0

Status

MailNews Core
Build Config
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: frg, Assigned: frg)

Tracking

unspecified
Thunderbird 53.0

Thunderbird Tracking Flags

(thunderbird53 fixed, seamonkey2.50 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
The define MOZ_INCOMPLETE_EXTERNAL_LINKAGE will no longer work after removal of binary components from m-c xpcom. Comments indicate that it was a developers only option. As far as I see it for it to work again Bug 1316450 and Bug 1314955 would both need to be backed out.  This wouldn't make any sense or better it will not happen so I think it should be removed.
(Assignee)

Comment 1

a year ago
Created attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

Patch. Not setting review yet. Need to test it first. If something thinks its a bad idea please let me know.
(Assignee)

Comment 2

a year ago
>> If something

Make it someone :)
(Assignee)

Comment 3

a year ago
Local build works fine. Will do a TB try build next.
(Assignee)

Comment 4

a year ago
Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

TB try build looks ok to me. Only the usual bustage in tests becaus of recent m-c changes I assume:)

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d9a68f7fcc51b90ae79635da90d9776db15f5530

Jorg, can oyu review it for TB or someone else?
Attachment #8812611 - Flags: review?(philip.chee)
Attachment #8812611 - Flags: review?(jorgk)
Attachment #8812611 - Flags: review?(iann_bugzilla)

Comment 5

a year ago
Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

Review of attachment 8812611 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8812611 - Flags: review?(jorgk) → review+

Comment 6

a year ago
Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

Looks reasonable.
Attachment #8812611 - Flags: review?(philip.chee) → review+
(Assignee)

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-seamonkey2.50: --- → fixed
status-thunderbird53: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.