Closed Bug 1318966 Opened 3 years ago Closed 3 years ago

Remove MOZ_INCOMPLETE_EXTERNAL_LINKAGE from c-c

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(thunderbird53 fixed, seamonkey2.50 fixed)

RESOLVED FIXED
Thunderbird 53.0
Tracking Status
thunderbird53 --- fixed
seamonkey2.50 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file)

The define MOZ_INCOMPLETE_EXTERNAL_LINKAGE will no longer work after removal of binary components from m-c xpcom. Comments indicate that it was a developers only option. As far as I see it for it to work again Bug 1316450 and Bug 1314955 would both need to be backed out.  This wouldn't make any sense or better it will not happen so I think it should be removed.
Patch. Not setting review yet. Need to test it first. If something thinks its a bad idea please let me know.
>> If something

Make it someone :)
Local build works fine. Will do a TB try build next.
Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

TB try build looks ok to me. Only the usual bustage in tests becaus of recent m-c changes I assume:)

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d9a68f7fcc51b90ae79635da90d9776db15f5530

Jorg, can oyu review it for TB or someone else?
Attachment #8812611 - Flags: review?(philip.chee)
Attachment #8812611 - Flags: review?(jorgk)
Attachment #8812611 - Flags: review?(iann_bugzilla)
Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

Review of attachment 8812611 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8812611 - Flags: review?(jorgk) → review+
Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

Looks reasonable.
Attachment #8812611 - Flags: review?(philip.chee) → review+
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 53.0
You need to log in before you can comment on or make changes to this bug.