1318966 - Remove MOZ_INCOMPLETE_EXTERNAL_LINKAGE from c-c

Status: RESOLVED FIXED

(MailNews Core :: Build Config, defect)

Description

[Frank-Rainer Grahl (:frg)]

The define MOZ_INCOMPLETE_EXTERNAL_LINKAGE will no longer work after removal of binary components from m-c xpcom. Comments indicate that it was a developers only option. As far as I see it for it to work again Bug 1316450 and Bug 1314955 would both need to be backed out.  This wouldn't make any sense or better it will not happen so I think it should be removed.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1318966-buildfilescleanup.patch

Patch. Not setting review yet. Need to test it first. If something thinks its a bad idea please let me know.

Comment 2

[Frank-Rainer Grahl (:frg)]

>> If something

Make it someone :)

Comment 3

[Frank-Rainer Grahl (:frg)]

Local build works fine. Will do a TB try build next.

Comment 4

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

TB try build looks ok to me. Only the usual bustage in tests becaus of recent m-c changes I assume:)

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d9a68f7fcc51b90ae79635da90d9776db15f5530

Jorg, can oyu review it for TB or someone else?

Comment 5

[aleth [:aleth]]

Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

Review of attachment 8812611 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 6

[Philip Chee]

Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

Looks reasonable.

Comment 7

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8812611 [details] [diff] [review]
1318966-buildfilescleanup.patch

https://hg.mozilla.org/comm-central/rev/7364d427246cc5712b0befd47ffff6e5eefc5372