Closed Bug 1319072 Opened 3 years ago Closed 3 years ago

Assertion failure: aCoeff >= 0.0 && aCoeff <= 1.0 (Coefficient should be in the range [0.0, 1.0]), atnsStyleTransformMatrix.cpp:332

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: cbook, Unassigned)

References

(Blocks 1 open bug, )

Details

(Keywords: assertion)

Attachments

(2 files)

Attached file stack
found by bughunter and reproduced on latest win trunk debug tinderbox build.

Steps to reproduce:
-> Load http://www.premiumoutlets.com/outlet/chicago/stores
---> wait some seconds
-----> Assertion failure: aCoeff >= 0.0 && aCoeff <= 1.0 (Coefficient should be in the range [0.0, 1.0]), at c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/layout/style/nsStyleTransformMatrix.cpp:332

debug trunk only - so seems a recent regression - maybe from bug 1304886 ?
hiro: could you take a look ? thanks!
Flags: needinfo?(hiikezoe)
That's right.  I am totally missing some easing functions produce values greater than 1.0.  But hmm, what should we do for such values?  gfxQuaternion::Slerp clamps the values,  it seems that we can't get plausible interpolated values.
Blocks: 1304886
Flags: needinfo?(hiikezoe)
Comment on attachment 8812958 [details]
Bug 1319072 - Don't assert even if coefficient is out of range [0, 1].

https://reviewboard.mozilla.org/r/94492/#review94810

Removing the assertions looks good to me.
Attachment #8812958 - Flags: review?(boris.chiou) → review+
Pushed by hiikezoe@mozilla-japan.org:
https://hg.mozilla.org/integration/autoland/rev/1f8649133d7c
Don't assert even if coefficient is out of range [0, 1]. r=boris
https://hg.mozilla.org/mozilla-central/rev/1f8649133d7c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.