1319072 - Assertion failure: aCoeff >= 0.0 && aCoeff <= 1.0 (Coefficient should be in the range [0.0, 1.0]), atnsStyleTransformMatrix.cpp:332

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: stack

found by bughunter and reproduced on latest win trunk debug tinderbox build.

Steps to reproduce:
-> Load http://www.premiumoutlets.com/outlet/chicago/stores
---> wait some seconds
-----> Assertion failure: aCoeff >= 0.0 && aCoeff <= 1.0 (Coefficient should be in the range [0.0, 1.0]), at c:/builds/moz2_slave/m-cen-w32-d-000000000000000000/build/src/layout/style/nsStyleTransformMatrix.cpp:332

debug trunk only - so seems a recent regression - maybe from bug 1304886 ?

Comment 1

[Carsten Book [:Tomcat]]

hiro: could you take a look ? thanks!

Comment 2

[Hiroyuki Ikezoe (:hiro)]

That's right.  I am totally missing some easing functions produce values greater than 1.0.  But hmm, what should we do for such values?  gfxQuaternion::Slerp clamps the values,  it seems that we can't get plausible interpolated values.

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Files a spec issue. https://github.com/w3c/csswg-drafts/issues/744

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1319072 - Don't assert even if coefficient is out of range [0, 1].

Review commit: https://reviewboard.mozilla.org/r/94492/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94492/

Comment 5

[Boris Chiou [:boris]]

Comment on attachment 8812958 [details]
Bug 1319072 - Don't assert even if coefficient is out of range [0, 1].

https://reviewboard.mozilla.org/r/94492/#review94810

Removing the assertions looks good to me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f8649133d7c
Don't assert even if coefficient is out of range [0, 1]. r=boris

Comment 7

[Hiroyuki Ikezoe (:hiro)]

Thank you, Boris!

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e3a0162ef72efbeeefe01d4287a0affd11c7175d

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1f8649133d7c