1319134 - (intersection-observer) Switch from idle callback to post task.

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Tobias Schneider [:tobytailor]]

See https://github.com/WICG/IntersectionObserver/pull/182.

Comment 1

[Tobias Schneider [:tobytailor]]

Attachment: Bug 1319134 - (intersection-observer) Switch from idle callback to post task.

Review commit: https://reviewboard.mozilla.org/r/110882/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110882/

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8835193 [details]
Bug 1319134 - (intersection-observer) Switch from idle callback to post task.

https://reviewboard.mozilla.org/r/110882/#review112514

So you now notify after one event loop trip after each refresh tick? Ok.
One problem here (which we might have had before) is that since refresh ticks have higher priority in the event loop, we might end up with two adjacent refresh ticks and then twe adjacent intersection observer notifications, instead of having them interleaved. I don't know if that's going to matter.

Comment 3

[Tobias Schneider [:tobytailor]]

We should be fine since the spec removed any mentioning of exact timing. Simply scheduling an event to be executed at next event loop iteration should be fine.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98b6a20708cd
(intersection-observer) Switch from idle callback to post task. r=mstange

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/98b6a20708cd