Closed Bug 1319151 Opened 3 years ago Closed 3 years ago

Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux

Categories

(Firefox :: Search, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 53
Tracking Status
firefox53 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

(Whiteboard: [fxsearch])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1318790 +++
Blocks: 1318790
No longer blocks: logspam, 1113747
No longer depends on: 1318790
Comment on attachment 8812857 [details]
Bug 1319151 - Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux.

https://reviewboard.mozilla.org/r/94424/#review94718
Attachment #8812857 - Flags: review?(florian) → review+
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c6556272fd4
Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux. r=florian
https://hg.mozilla.org/mozilla-central/rev/2c6556272fd4
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Attached patch Aurora patchSplinter Review
This is a follow-up to bug 1318790.  That bug must land first.

Approval Request Comment
[Feature/regressing bug #]: Bug 1318790
[User impact if declined]: If bug 1318790 is accepted on Aurora but this one isn't, users on macOS will see a slightly different highlight state appearance for one item in the searchbar popup, compared to Windows and Linux users
[Describe test coverage new/current, TreeHerder]: Manual testing, no automated testing needed
[Risks and why]: Very low risk, only two CSS lines changed
[String/UUID change made/needed]: None
Attachment #8813480 - Flags: approval-mozilla-aurora?
Comment on attachment 8813480 [details] [diff] [review]
Aurora patch

if bug 1113747 is not going into 52 then this isn't needed, aiui
Attachment #8813480 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
You need to log in before you can comment on or make changes to this bug.