Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux

RESOLVED FIXED in Firefox 53

Status

()

Firefox
Search
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: adw, Assigned: adw)

Tracking

Trunk
Firefox 53
Points:
---

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [fxsearch])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #1318790 +++
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Blocks: 1318790
No longer blocks: 765224, 1113747
No longer depends on: 1318790
Comment on attachment 8812857 [details]
Bug 1319151 - Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux.

https://reviewboard.mozilla.org/r/94424/#review94718
Attachment #8812857 - Flags: review?(florian) → review+

Comment 3

2 years ago
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2c6556272fd4
Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux. r=florian

Comment 4

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2c6556272fd4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 53
Created attachment 8813480 [details] [diff] [review]
Aurora patch

This is a follow-up to bug 1318790.  That bug must land first.

Approval Request Comment
[Feature/regressing bug #]: Bug 1318790
[User impact if declined]: If bug 1318790 is accepted on Aurora but this one isn't, users on macOS will see a slightly different highlight state appearance for one item in the searchbar popup, compared to Windows and Linux users
[Describe test coverage new/current, TreeHerder]: Manual testing, no automated testing needed
[Risks and why]: Very low risk, only two CSS lines changed
[String/UUID change made/needed]: None
Attachment #8813480 - Flags: approval-mozilla-aurora?
Comment on attachment 8813480 [details] [diff] [review]
Aurora patch

if bug 1113747 is not going into 52 then this isn't needed, aiui
Attachment #8813480 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
You need to log in before you can comment on or make changes to this bug.