1319151 - Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux

Status: RESOLVED FIXED

(Firefox :: Search, defect, P2)

Description

[Drew Willcoxon :adw]

+++ This bug was initially created as a clone of Bug #1318790 +++

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1319151 - Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux.

Review commit: https://reviewboard.mozilla.org/r/94424/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94424/

Comment 2

[Florian Quèze [:florian]]

Comment on attachment 8812857 [details]
Bug 1319151 - Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux.

https://reviewboard.mozilla.org/r/94424/#review94718

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c6556272fd4
Bug 1318790 followup: Apply searchbar add-engine overflow menu CSS changes to Windows and Linux. r=florian

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c6556272fd4

Comment 5

[Drew Willcoxon :adw]

Attachment: Aurora patch

This is a follow-up to bug 1318790.  That bug must land first.

Approval Request Comment
[Feature/regressing bug #]: Bug 1318790
[User impact if declined]: If bug 1318790 is accepted on Aurora but this one isn't, users on macOS will see a slightly different highlight state appearance for one item in the searchbar popup, compared to Windows and Linux users
[Describe test coverage new/current, TreeHerder]: Manual testing, no automated testing needed
[Risks and why]: Very low risk, only two CSS lines changed
[String/UUID change made/needed]: None

Comment 6

[Julien Cristau [:jcristau]]

Comment on attachment 8813480 [details] [diff] [review]
Aurora patch

if bug 1113747 is not going into 52 then this isn't needed, aiui