Open Bug 1319184 Opened 5 years ago Updated 2 years ago

remove the IsInPrivateBrowsing boolean from the GetFavicon related code in DocShell

Categories

(Firefox :: Private Browsing, defect, P3)

defect

Tracking

()

Tracking Status
firefox57 --- fix-optional

People

(Reporter: huseby, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [OA])

The function CopyFavicon in DocShell takes both a loading principal and a private browsing boolean.  Since we're switching to origin attributes attached to the principal, we no longer need the private browsing boolean.  The nsCopyFaviconCallback class has the redundant boolean as well.  This bugs is for removing the boolean from those places:

http://searchfox.org/mozilla-central/rev/62db1c9021cfbde9fa5e6e9601de16c21f4c7ce4/docshell/base/nsDocShell.cpp#10428
http://searchfox.org/mozilla-central/rev/62db1c9021cfbde9fa5e6e9601de16c21f4c7ce4/docshell/base/nsDocShell.cpp#12093
http://searchfox.org/mozilla-central/rev/62db1c9021cfbde9fa5e6e9601de16c21f4c7ce4/docshell/base/nsDocShell.cpp#9497
Tanvi, what's the priority on this bug?  Should I fix this now or are there more important things?
Status: NEW → ASSIGNED
Flags: needinfo?(tanvi)
Assignee: huseby → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(tanvi)
Priority: -- → P3
Depends on: 1321646
You need to log in before you can comment on or make changes to this bug.