1319226 - Process JARManifests in the tup backend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

We'll need to handle the JARManifest moz.build objects in the tup backend. Some of the logic for these is in rules.mk, which ends up invoking the jar_maker py_action.

Comment 1

[Michael Shal [:mshal]]

glandium pointed out that these can be handled easily by using the CommonBackend:_consume_jar_manifest() function, which essentially converts them into the FinalTargetFiles / FinalTargetPreprocessedFiles that the tup backend already handles.

Comment 2

[Michael Shal [:mshal]]

Attachment: Bug 1319226 - allow symlinks to point to files with a different basename;

Some jar.mn files create symlinks with a different name than the file
they point to. The tup backend should support this by using the object's
target_basename as the destination filename.

Review commit: https://reviewboard.mozilla.org/r/143522/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143522/

Comment 3

[Michael Shal [:mshal]]

Attachment: Bug 1319226 - Process JARManifests in the tup backend;

The JARManifests are relatively straightforward since they can be
converted into FinalTargetFiles by _consume_jar_manifest(). Since these
can contain RenamedSourcePaths, we no longer assert an error for those.
The main difference is that some JARManifests can result in
preprocessing .css files, which use a different marker than the default.

The two odd cases are bookmarks.html.in and buildconfig.html. The first
relies on an l10n define in a Makefile, while the latter needs CXXFLAGS.
The faster make backend works around these by defining
BOOKMARKS_INCLUDE_DIR to the en-US version, and skips the CXXFLAGS case
by defining BUILD_FASTER=1, so that is what the tup backend does for now
as well.

Review commit: https://reviewboard.mozilla.org/r/143524/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143524/

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8871980 [details]
Bug 1319226 - allow symlinks to point to files with a different basename;

https://reviewboard.mozilla.org/r/143522/#review148122

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8871981 [details]
Bug 1319226 - Process JARManifests in the tup backend;

https://reviewboard.mozilla.org/r/143524/#review148134

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bce19249d9b
allow symlinks to point to files with a different basename; r=chmanchester
https://hg.mozilla.org/integration/autoland/rev/9e738d40b62d
Process JARManifests in the tup backend; r=chmanchester

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9bce19249d9b
https://hg.mozilla.org/mozilla-central/rev/9e738d40b62d