1319227 - Process ObjdirFiles / ObjdirPreprocessedFiles in the tup backend

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Michael Shal [:mshal]]

These are similar to the FinalTargetFiles objects, so they should be fairly straightforward to implement.

Comment 1

[Michael Shal [:mshal]]

Bug 1319637 turned these into FinalTargetFiles directly, so we just need to slightly fix up the FinalTargetFiles processing and we'll get these as well.

Comment 2

[Michael Shal [:mshal]]

Attachment: Bug 1319227 - Support ObjdirFiles in tup;

Review commit: https://reviewboard.mozilla.org/r/97534/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/97534/

Comment 3

[Chris Manchester (Offline Aug 16-22)]

Comment on attachment 8817102 [details]
Bug 1319227 - Support ObjdirFiles in tup;

https://reviewboard.mozilla.org/r/97534/#review97936

::: python/mozbuild/mozbuild/backend/tup.py
(Diff revision 1)
> -
>          for path, files in obj.files.walk():
>              backend_file = self._get_backend_file(mozpath.join(target, path))
>              for f in files:
>                  assert not isinstance(f, RenamedSourcePath)
> -                dest = mozpath.join(reltarget, path, f.target_basename)

I guess this was already unused, hm.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c698b01dfe8
Support ObjdirFiles in tup; r=chmanchester

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c698b01dfe8