Closed
Bug 1319310
Opened 9 years ago
Closed 9 years ago
TabParent can fail to initialize during a GPU process restart
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla53
| Tracking | Status | |
|---|---|---|
| firefox53 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.47 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
If the GPU process dies during PBrowser initialization, we might not completely integrate it into the layers system.
|
Assignee | |
Comment 1•9 years ago
|
||
This is similar to bug 1314520. During PBrowser initialization we send a bunch of messages to the compositor. We don't particularly care whether they succeed, since all of this stuff is ultimately restarted if it fails. However, we do need tab initialization to complete in order for the restart mechanism to work.
Therefore, RenderFrameParent::Init should not early-return.
Attachment #8813011 -
Flags: review?(wmccloskey)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Assertion that we were hitting: http://searchfox.org/mozilla-central/rev/904bf9addd03b03d4cad11b82f19f43d875b7f27/dom/ipc/TabChild.cpp#1225
Attachment #8813011 -
Flags: review?(wmccloskey) → review+
Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f07c7ecdd266
Mark RenderFrameParent as initialized even if it failed to message the remote compositor. (bug 1319310, r=billm)
|
||
Comment 4•9 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox53:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in
before you can comment on or make changes to this bug.
Description
•