1319330 - Clang complains bad implicit conversion constructor for the header file exception of VS 2015

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Ting-Yu Chou [:ting] (away)]

While working on bug 1316545 I ran into this:

 0:22.67 error(clang): 'error' diagnostics seen but not expected:
 0:22.67   File C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\exception Line 142: bad implicit conversion constructor for 'bad_exception'
 0:22.67   File C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\exception Line 175: bad implicit conversion constructor for 'bad_alloc'
 0:22.67 error(clang): 'note' diagnostics seen but not expected:
 0:22.67   File C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\exception Line 142: consider adding the explicit keyword to the constructor
 0:22.67   File C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\INCLUDE\exception Line 175: consider adding the explicit keyword to the constructor

I workarounded it by adding "explicit" to my local file, but for taskcluster probably it requires customized built vs2015 on tooltool.

Comment 1

[(Away)]

Surely there must be a way to make system headers exempt from static analysis requirements, no?

Comment 2

[(no longer active)]

Attachment: Ignore system headers for the implicit constructor check

Ting-Yu, can you please test this patch?

Comment 3

[Ting-Yu Chou [:ting] (away)]

Comment on attachment 8813249 [details] [diff] [review]
Ignore system headers for the implicit constructor check

Yes, it works.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbbb7be5fe57
Ignore system headers for the implicit constructor check; r=mystor

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cbbb7be5fe57