Remove "browser.newtab.url" from TelemetryEnvironment user prefs

RESOLVED FIXED in Firefox 53

Status

()

Toolkit
Telemetry
P3
normal
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: gfritzsche, Assigned: kalpa, Mentored)

Tracking

Trunk
mozilla53
Points:
1

Firefox Tracking Flags

(firefox53 fixed)

Details

(Whiteboard: [measurement:client] [lang=js] [good first bug])

Attachments

(1 attachment, 5 obsolete attachments)

(Reporter)

Description

5 months ago
The pref "browser.newtab.url" was removed per bug 1118285, we should stop recording it in TelemetryEnvironment too.

Updated

5 months ago
Mentor: chutten@mozilla.com
Whiteboard: [measurement:client] → [measurement:client] [good first bug]
(Reporter)

Updated

5 months ago
Priority: P2 → P3
(Reporter)

Updated

5 months ago
Whiteboard: [measurement:client] [good first bug] → [measurement:client] [lang=js] [good first bug]
(Reporter)

Comment 1

5 months ago
This is the file where it needs to be removed in:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetryEnvironment.jsm

After removal, we should confirm the tests still run fine:
mach build && mach xpcshell-test toolkit/components/telemetry/tests/unit
(Assignee)

Comment 2

5 months ago
I have worked on this bug. How to patch and submit for review?
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Attachment #8816210 - Flags: review?(gfritzsche)
(Reporter)

Updated

5 months ago
Assignee: nobody → avikalpakundu
(Reporter)

Comment 4

5 months ago
mozreview-review
Comment on attachment 8816210 [details]
Bug 1319368 - Remove "browser.newtab.url" from TelemetryEnvironment user prefs

https://reviewboard.mozilla.org/r/97000/#review97496

There is an unrelated change in this patch:
> diff --git a/tools/quitter/chrome.manifest b/tools/quitter/chrome.manifest
> old mode 100644
> new mode 100755

Please revert that change, the rest looks good, thanks.
Attachment #8816210 - Flags: review?(gfritzsche)
(Reporter)

Updated

5 months ago
Mentor: gfritzsche@mozilla.com
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Attachment #8816210 - Attachment is obsolete: true
(Assignee)

Updated

5 months ago
Attachment #8816458 - Attachment is obsolete: true
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Attachment #8816501 - Attachment is obsolete: true
(Assignee)

Updated

5 months ago
Attachment #8816502 - Attachment is obsolete: true
Attachment #8816502 - Flags: review?(gfritzsche)
(Assignee)

Comment 8

5 months ago
Created attachment 8816507 [details] [diff] [review]
Patch for this bug.

Patch for this bug.
Attachment #8816507 - Flags: review?(gfritzsche)
(Reporter)

Comment 9

5 months ago
Comment on attachment 8816507 [details] [diff] [review]
Patch for this bug.

Review of attachment 8816507 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me!
Can you upload this with a proper commit message?
I.e. "Bug 1319368 - Remove ... r=gfritzsche".
Attachment #8816507 - Flags: review?(gfritzsche) → review+
(Assignee)

Comment 10

5 months ago
Comment on attachment 8816507 [details] [diff] [review]
Patch for this bug.

Bug 1319368 - Remove "browser.newtab.url" from TelemetryEnvironment user prefs r=gfritzsche
(Assignee)

Comment 11

5 months ago
Created attachment 8816874 [details] [diff] [review]
Bug 1319368 - Remove "browser.newtab.url" from TelemetryEnvironment user prefs r=gfritzsche

Bug 1319368 - Remove "browser.newtab.url" from TelemetryEnvironment user prefs r=gfritzsche
Attachment #8816507 - Attachment is obsolete: true
Attachment #8816874 - Flags: review+

Comment 12

5 months ago
Adding checkin-needed so it'll get picked up. Sorry for the delay!
Keywords: checkin-needed

Comment 13

5 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/133569bc2317
"Remove "browser.newtab.url" from TelemetryEnvironment user prefs". r=gfritzsche
Keywords: checkin-needed

Comment 14

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/133569bc2317
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.