Closed Bug 1319368 Opened 6 years ago Closed 6 years ago

Remove "browser.newtab.url" from TelemetryEnvironment user prefs

Categories

(Toolkit :: Telemetry, defect, P3)

Product:
Toolkit
Component:
Telemetry
Type:
defect
Points:
1

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla53
Tracking Flags:
Tracking Status
firefox53 --- fixed

People

(Reporter: gfritzsche, Assigned: kalpa, Mentored)

Details

(Whiteboard: [measurement:client] [lang=js] [good first bug])

Attachments

(1 file, 5 obsolete files)

Bug 1319368 - Remove "browser.newtab.url" from TelemetryEnvironment user prefs r=gfritzsche
615 bytes, patch
kalpa
: review+
Details | Diff | Splinter Review 
The pref "browser.newtab.url" was removed per bug 1118285, we should stop recording it in TelemetryEnvironment too.
Mentor: chutten
Whiteboard: [measurement:client] → [measurement:client] [good first bug]
Priority: P2 → P3
Whiteboard: [measurement:client] [good first bug] → [measurement:client] [lang=js] [good first bug]
This is the file where it needs to be removed in:
https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetryEnvironment.jsm

After removal, we should confirm the tests still run fine:
mach build && mach xpcshell-test toolkit/components/telemetry/tests/unit
I have worked on this bug. How to patch and submit for review?
Attachment #8816210 - Flags: review?(gfritzsche)
Assignee: nobody → avikalpakundu
Comment on attachment 8816210 [details]
Bug 1319368 - Remove "browser.newtab.url" from TelemetryEnvironment user prefs

https://reviewboard.mozilla.org/r/97000/#review97496

There is an unrelated change in this patch:
> diff --git a/tools/quitter/chrome.manifest b/tools/quitter/chrome.manifest
> old mode 100644
> new mode 100755

Please revert that change, the rest looks good, thanks.
Attachment #8816210 - Flags: review?(gfritzsche)
Mentor: gfritzsche
Attachment #8816210 - Attachment is obsolete: true
Attachment #8816458 - Attachment is obsolete: true
Attachment #8816501 - Attachment is obsolete: true
Attachment #8816502 - Attachment is obsolete: true
Attachment #8816502 - Flags: review?(gfritzsche)
Attached patch Patch for this bug. (obsolete) — — Splinter Review 
Patch for this bug.
Attachment #8816507 - Flags: review?(gfritzsche)
Comment on attachment 8816507 [details] [diff] [review]
Patch for this bug.

Review of attachment 8816507 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me!
Can you upload this with a proper commit message?
I.e. "Bug 1319368 - Remove ... r=gfritzsche".
Attachment #8816507 - Flags: review?(gfritzsche) → review+
Comment on attachment 8816507 [details] [diff] [review]
Patch for this bug.

Bug 1319368 - Remove "browser.newtab.url" from TelemetryEnvironment user prefs r=gfritzsche
Bug 1319368 - Remove "browser.newtab.url" from TelemetryEnvironment user prefs r=gfritzsche
Attachment #8816507 - Attachment is obsolete: true
Attachment #8816874 - Flags: review+
Adding checkin-needed so it'll get picked up. Sorry for the delay!
Keywords: checkin-needed
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/133569bc2317
"Remove "browser.newtab.url" from TelemetryEnvironment user prefs". r=gfritzsche
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/133569bc2317
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox53: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla53
You need to log in before you can comment on or make changes to this bug.