Closed Bug 1319401 Opened 4 years ago Closed 4 years ago

Convert some code in editor/ to C++11

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set
normal

Tracking

(firefox53 fixed)

RESOLVED FIXED
mozilla53
Tracking Status
firefox53 --- fixed

People

(Reporter: andi, Assigned: andi)

References

Details

Attachments

(2 files)

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators
Attachment #8813158 - Flags: review?(masayuki)
Attachment #8813159 - Flags: review?(masayuki)
In the second patch we added override even if in the definition of NS_IMETHOD we have virtual, but i think it's more visible to have it declared as override.
Comment on attachment 8813158 [details]
Bug 1319401 - Replace default bodies of special member functions with = default; in editor/.

https://reviewboard.mozilla.org/r/94680/#review95148

Thanks!
Attachment #8813158 - Flags: review?(masayuki) → review+
Comment on attachment 8813159 [details]
Bug 1319401 - Use C++11's override and remove virtual where applicable in editor/.

https://reviewboard.mozilla.org/r/94682/#review95150
Attachment #8813159 - Flags: review?(masayuki) → review+
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c616addd454
Replace default bodies of special member functions with = default; in editor/. r=masayuki
https://hg.mozilla.org/integration/autoland/rev/7e495dade309
Use C++11's override and remove virtual where applicable in editor/. r=masayuki
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.