1319408 - Convert some code in embedding/ to C++11

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Andi [:andi]]

Using the checkers provided by clang-tidy we can refresh the code to make it use the features of C++11 like:

- auto variables declarations
- default CTORS and DTORS
- using new range loop operators

Comment 1

[Andi [:andi]]

Attachment: Bug 1319408 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in embedding/.

Review commit: https://reviewboard.mozilla.org/r/94690/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94690/

Comment 2

[Andi [:andi]]

Attachment: Bug 1319408 - Replace default bodies of special member functions with = default; in embedding/.

Review commit: https://reviewboard.mozilla.org/r/94692/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94692/

Comment 3

[Andi [:andi]]

Attachment: Bug 1319408 - Replace string literals containing escaped characters with raw string literals in embedding/.

Review commit: https://reviewboard.mozilla.org/r/94694/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94694/

Comment 4

[Andi [:andi]]

Attachment: Bug 1319408 - Replace integer literals which are cast to bool in embedding/.

Review commit: https://reviewboard.mozilla.org/r/94696/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94696/

Comment 5

[Andi [:andi]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f7d4401212473e78377ca63903054a3a0c5e1705

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8813165 [details]
Bug 1319408 - Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in embedding/.

https://reviewboard.mozilla.org/r/94690/#review96078

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8813168 [details]
Bug 1319408 - Replace integer literals which are cast to bool in embedding/.

https://reviewboard.mozilla.org/r/94696/#review96084

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8813166 [details]
Bug 1319408 - Replace default bodies of special member functions with = default; in embedding/.

https://reviewboard.mozilla.org/r/94692/#review96080

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 8813167 [details]
Bug 1319408 - Replace string literals containing escaped characters with raw string literals in embedding/.

https://reviewboard.mozilla.org/r/94694/#review96082

Comment 10

[Myk Melez [:myk] [@mykmelez]]

(In reply to Andi-Bogdan Postelnicu from comment #0)
> Using the checkers provided by clang-tidy we can refresh the code to make it
> use the features of C++11 like:
> 
> - auto variables declarations
> - default CTORS and DTORS
> - using new range loop operators

All reasonable changes.

Aside: any chance we'll be adding clang-tidy to CI, so we can catch any attempts to reintroduce such nits?

Comment 11

[Sylvestre Ledru [:Sylvestre]]

> Aside: any chance we'll be adding clang-tidy to CI, so we can catch any attempts to reintroduce such nits?
Yes, we tried first to evaluate the reaction of developers (very positive), we will see how to implement that in the best way possible.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/556fa82a09ea
Use auto type specifier where aplicable for variable declarations to improve code readability and maintainability in embedding/. r=myk
https://hg.mozilla.org/integration/autoland/rev/2f5c53658a03
Replace default bodies of special member functions with = default; in embedding/. r=myk
https://hg.mozilla.org/integration/autoland/rev/096d333c2ba2
Replace string literals containing escaped characters with raw string literals in embedding/. r=myk
https://hg.mozilla.org/integration/autoland/rev/ac823431b8ad
Replace integer literals which are cast to bool in embedding/. r=myk

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/556fa82a09ea
https://hg.mozilla.org/mozilla-central/rev/2f5c53658a03
https://hg.mozilla.org/mozilla-central/rev/096d333c2ba2
https://hg.mozilla.org/mozilla-central/rev/ac823431b8ad