1319419 - Unnecessary buttons shapes in add-on confirmation pop-up

Status: VERIFIED FIXED

(Firefox :: Site Identity, defect)

Description

[Vasilica Tamas, QA [:vtamas]]

[Affected versions]:
Firefox 53.0a1 (2016-11-22)


[Affected platforms]:
Windows 10 64-bit
Ubuntu 16.04 32-bit


[Steps to reproduce]:
1.Launch Firefox with clean profile.
2.Navigate to https://addons.mozilla.org and install an add-on.
3.Pay attention to the last add-on notification pop-up.


[Expected Results]:
There are no buttons displayed in add-on confirmation pop-up.


[Actual Results]:
“Cancel” and “Install” buttons shapes are still displayed in add-on confirmation pop-up.
See screenshots: http://www.screencast.com/t/tFbQuFhG0 , http://www.screencast.com/t/kThUjGMq


[Regression Range]:
Last good revision: abecacadf9d3006029eb2208445521f495e80a70
First bad revision: 2e3bef583561c4812e6093a5ec639b1a58d0ab18
Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=abecacadf9d3006029eb2208445521f495e80a70&tochange=2e3bef583561c4812e6093a5ec639b1a58d0ab18


I suspect that this issue was regressed by Bug 1201896

Comment 1

[:Paolo Amadini]

This will be handled by bug 1315236, but keeping this one open for verification.

Comment 2

[Johann Hofmann [:johannh]]

Fixed in bug 1315236.

Comment 3

[Vasilica Tamas, QA [:vtamas]]

Confirm that the “Cancel” and “Install” buttons shapes are no longer displayed in add-on confirmation pop-up and the "Ok" button which is displayed now successfully closes the doorhanger: http://screencast.com/t/wy8CpEAqE
Tested on Firefox 53.0a1 (2016-11-29) and Firefox 52.0a2 (2016-11-29) under Windows 10 64-bit and Ubuntu 16.04 32-bit.