1319452 - Background page should be private in permanent private browsing mode

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Adolf Daniel]

Attachment: test_ext.zip

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_1) AppleWebKit/602.2.14 (KHTML, like Gecko) Version/10.0.1 Safari/602.2.14

Steps to reproduce:

1. Enable "Private Browsing Mode" by default in Firefox 50 and restart the browser
2. Load the attached webExtension
3. Click on the extension button


Actual results:

It shows "hi" in the popup displayed. The error 'Error: Permission denied to access property "testData"' is shown in the console.

The background window object returned by the call chrome.extension.getBackgroundPage() is inaccessible. The chrome.runtime.getBackgroundPage(callback) also has the same issue.

This issue is not reproducible in Firefox 49.0.2. 
This issue is not reproducible in Firefox 50 if "private browsing mode" is disabled


Expected results:

It should say "hello" in the popup displayed. The properties of window object returned by chrome.extension.getBackgroudPage() should be accessible.

Comment 2

[Kris Maglione [:kmag]]

Reopening, as there seem to be multiple issues here.

I can reproduce this in 50+. The reason it's not reproducible in 49 is that privateBrowsingId was not an origin attribute at that point, so cross-origin access was still allowed.

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1319452: Part 1 - Load background page in private browsing mode during permanent private browsing.

Review commit: https://reviewboard.mozilla.org/r/94796/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94796/

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1319452: Part 2 - Don't expose extension views that the caller cannot access.

Review commit: https://reviewboard.mozilla.org/r/94798/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94798/

Comment 5

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813381 [details]
Bug 1319452: Part 1 - Load background page in private browsing mode during permanent private browsing.

https://reviewboard.mozilla.org/r/94796/#review95064

Comment 6

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8813382 [details]
Bug 1319452: Part 2 - Don't expose extension views that the caller cannot access.

https://reviewboard.mozilla.org/r/94798/#review95066

Comment 7

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/926f21451281f50f9172366b534a684ab85f64eb
Bug 1319452: Part 1 - Load background page in private browsing mode during permanent private browsing. r=billm

https://hg.mozilla.org/integration/mozilla-inbound/rev/1846a78b62ff79f695c81c741cb1f15c9c2cda28
Bug 1319452: Part 2 - Don't expose extension views that the caller cannot access. r=billm

Comment 8

[Kris Maglione [:kmag]]

Comment on attachment 8813381 [details]
Bug 1319452: Part 1 - Load background page in private browsing mode during permanent private browsing.

Approval Request Comment
[Feature/regressing bug #]: Bug 1269361
[User impact if declined]: This causes add-ons which require communication with their background pages to break in permanent private browsing mode.
[Describe test coverage new/current, TreeHerder]: The related features are covered by extensive tests, and new tests have been added for this issue.
[Risks and why]: Low. This should only have an effect in cases where things are already behaving incorrectly. In those cases, any negative effects are almost certain to be less problematic than the issues this resolves.
[String/UUID change made/needed]: None

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/926f21451281
https://hg.mozilla.org/mozilla-central/rev/1846a78b62ff

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8813381 [details]
Bug 1319452: Part 1 - Load background page in private browsing mode during permanent private browsing.

This is a 50.0.1 dot release ride-along. Let's land this on m-r relbranch.

Comment 11

[Kris Maglione [:kmag]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6e687af3b7cb22c4f0f5fce6d08e7e266bbe191b
https://hg.mozilla.org/releases/mozilla-aurora/rev/08b67f1167751fd9cde52cd0f3da8da46e65426e

https://hg.mozilla.org/releases/mozilla-beta/rev/0d8d75042332b977ceebf846ed5edc1a1ed2d696
https://hg.mozilla.org/releases/mozilla-beta/rev/b0b77569df6600517d9e6d73a8ebbc990f485063

https://hg.mozilla.org/releases/mozilla-release/rev/313505a1047e248f591b8345765090a609512581
https://hg.mozilla.org/releases/mozilla-release/rev/0bb3236cb12af980fcf222a50e441fd5395d8df3

Comment 12

[Ryan VanderMeulen [:RyanVM]]

FIREFOX_50_0_1_RELBRANCH (50.0.1):
https://hg.mozilla.org/releases/mozilla-release/rev/48c508bfdbac
https://hg.mozilla.org/releases/mozilla-release/rev/bffe68e9576f

Comment 13

[Paul Silaghi, QA [:pauly]]

Reproduced the issue on FX 50.
Verified fixed FX 50.0.1, 52.0a2 (2016-11-24) Win 7.

Comment 15

[Kyle]

I am still seeing this issue with my addon in 51.0.1.